aerc/commands/account, branch master Mirror of https://git.sr.ht/~sircmpwn/aerc create OriginalMail struct 2020-01-09T19:31:19+00:00 Leszek Cimała ernierasta@zori.cz 2020-01-08T20:44:14+00:00 bf28e23933a9808820ef4855257accf4634068e9 






Fix crash when no message is selected
2019-12-04T14:45:07+00:00

Wiktor Kwapisiewicz
wiktor@metacode.biz

2019-11-28T18:20:45+00:00

abd9e78f024580d476cb299a575a7aa54c53a4b4

Pressing `Enter` on a view that has not yet loaded messages (e.g. at
startup) would return `nil` from `Selected()`. Accessing `msg.Uid` on a
`nil` reference crashes aerc.

This patch moves the `msg == nil` check before accessing `msg.Uid` thus
avoiding the crash.

To test this patch repeatedly press `Enter` on startup.





Pressing `Enter` on a view that has not yet loaded messages (e.g. at
startup) would return `nil` from `Selected()`. Accessing `msg.Uid` on a
`nil` reference crashes aerc.

This patch moves the `msg == nil` check before accessing `msg.Uid` thus
avoiding the crash.

To test this patch repeatedly press `Enter` on startup.







commands/account: Disable :view for deleted msgs
2019-11-17T18:19:42+00:00

Kevin Kuehler
keur@xcf.berkeley.edu

2019-11-10T23:22:35+00:00

4966b912c6612768a21c3092fd197124ed504ae9

Allowing the user to view deleted messages creates all sorts of race
conditions. The most devious race condition is pv.source can be set to a
nil while another PartViewer is still running a goroutine in
attemptCopy.

Here is a trace when this happens.

goroutine 76 [running]: io.copyBuffer(0x7f8ad02641d0, 0xc00040f590, 0x0,
0x0, 0xc0007cc000, 0x8000, 0x8000, 0x0, 0x0, 0x8b3d60)
/usr/lib/go/src/io/io.go:402 +0x101 io.Copy(...)
/usr/lib/go/src/io/io.go:364
git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy.func4(0xc00017efd0,
0xc0004da7c0) /home/keur/repos/aerc/widgets/msgviewer.go:576 +0x611
created by git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy
/home/keur/repos/aerc/widgets/msgviewer.go:544 +0x144

We could add a guard in store.FetchBodyPart to only call the callback
when msg.Part.Reader != nil, but we still get a hanging pager. Therefore
it seems more reasonable to disable this completely.

Signed-off-by: Kevin Kuehler <keur@xcf.berkeley.edu>





Allowing the user to view deleted messages creates all sorts of race
conditions. The most devious race condition is pv.source can be set to a
nil while another PartViewer is still running a goroutine in
attemptCopy.

Here is a trace when this happens.

goroutine 76 [running]: io.copyBuffer(0x7f8ad02641d0, 0xc00040f590, 0x0,
0x0, 0xc0007cc000, 0x8000, 0x8000, 0x0, 0x0, 0x8b3d60)
/usr/lib/go/src/io/io.go:402 +0x101 io.Copy(...)
/usr/lib/go/src/io/io.go:364
git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy.func4(0xc00017efd0,
0xc0004da7c0) /home/keur/repos/aerc/widgets/msgviewer.go:576 +0x611
created by git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy
/home/keur/repos/aerc/widgets/msgviewer.go:544 +0x144

We could add a guard in store.FetchBodyPart to only call the callback
when msg.Part.Reader != nil, but we still get a hanging pager. Therefore
it seems more reasonable to disable this completely.

Signed-off-by: Kevin Kuehler <keur@xcf.berkeley.edu>







Add Templates with Parsing
2019-11-10T15:15:49+00:00

Srivathsan Murali
sri@vathsan.com

2019-11-03T12:51:14+00:00

3ba69edab5f0c787424dac9649e43a7743da13ca

+ Changes NewComposer to return error.
+ Add lib to handle templates using "text/template".
+ Add -T option to following commands
    - compose.
    - reply
    - forward
+ Quoted replies using templates.
+ Forwards as body using templates
+ Default templates are installed similar to filters.
+ Templates Config in aerc.conf.
    - Required templates are parsed while loading config.
+ Add aerc-templates.7 manual for using template data.





+ Changes NewComposer to return error.
+ Add lib to handle templates using "text/template".
+ Add -T option to following commands
    - compose.
    - reply
    - forward
+ Quoted replies using templates.
+ Forwards as body using templates
+ Default templates are installed similar to filters.
+ Templates Config in aerc.conf.
    - Required templates are parsed while loading config.
+ Add aerc-templates.7 manual for using template data.







Make commands join args with spaces
2019-09-20T19:06:34+00:00

Jeffas
dev@jeffas.io

2019-09-20T16:16:29+00:00

39307a6fa7e96641b822ed0a9acb75021dcf7fe9

This patch ensures the following commands join their arguments with
spaces to make it easier to interact with:

- cf
- mkdir
- cd
- attach
- detach
- ct
- copy
- move
- save





This patch ensures the following commands join their arguments with
spaces to make it easier to interact with:

- cf
- mkdir
- cd
- attach
- detach
- ct
- copy
- move
- save







Add sorting functionality
2019-09-20T18:56:02+00:00

Jeffas
dev@jeffas.io

2019-09-19T22:37:44+00:00

90d26da58a4af2d34328f5916adf3781222966c6

There is a command and config option. The criteria are a list of the
sort criterion and each can be individually reversed.

This only includes support for sorting in the maildir backend currently.
The other backends are not supported in this patch.





There is a command and config option. The criteria are a list of the
sort criterion and each can be individually reversed.

This only includes support for sorting in the maildir backend currently.
The other backends are not supported in this patch.







Add signatures
2019-09-12T20:18:34+00:00

Jeffas
dev@jeffas.io

2019-09-11T19:28:14+00:00

e2d5c456dc27f958d79fdf740c7b0852b2af4160

This adds the ability for per-account signatures in the accounts.conf
config file. The signature is added to emails in the editor at the
bottom of the email. This includes when forwarding, replying to, and
composing emails.

There are two config options: signature-file and signature-cmd. The
former allows a signature to be read from a file and the latter allows
an arbitrary command to be executed to return the signature.

The config options have been documented in aerc-config





This adds the ability for per-account signatures in the accounts.conf
config file. The signature is added to emails in the editor at the
bottom of the email. This includes when forwarding, replying to, and
composing emails.

There are two config options: signature-file and signature-cmd. The
former allows a signature to be read from a file and the latter allows
an arbitrary command to be executed to return the signature.

The config options have been documented in aerc-config







commands: move ParseNextPrevMessage error value to its last return value
2019-09-05T02:30:57+00:00

Wagner Riffel
wgrriffel@gmail.com

2019-09-03T19:34:06+00:00

bdb5e3e6581169bdb1d912c158336f409151b491

Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>





Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>







all: rewrite references to strings.Index to strings.Contains
2019-09-05T02:30:57+00:00

Wagner Riffel
wgrriffel@gmail.com

2019-09-03T19:34:05+00:00

baa70469c3b25e1b937c9c2a9e0b16762a227bca

Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>





Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>







all: use fmt.Errorf for fomartting errors
2019-09-05T02:30:57+00:00

Wagner Riffel
wgrriffel@gmail.com

2019-09-03T19:34:04+00:00

feacca3c5caffb11be1f5f7cbfef01400b5bc944

Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>





Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>