<feed xmlns='http://www.w3.org/2005/Atom'>
<title>aerc/commands, branch 0.3.0</title>
<subtitle>Mirror of https://git.sr.ht/~sircmpwn/aerc
</subtitle>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/'/>
<entry>
<title>commands/account: Disable :view for deleted msgs</title>
<updated>2019-11-17T18:19:42+00:00</updated>
<author>
<name>Kevin Kuehler</name>
<email>keur@xcf.berkeley.edu</email>
</author>
<published>2019-11-10T23:22:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=4966b912c6612768a21c3092fd197124ed504ae9'/>
<id>4966b912c6612768a21c3092fd197124ed504ae9</id>
<content type='text'>
Allowing the user to view deleted messages creates all sorts of race
conditions. The most devious race condition is pv.source can be set to a
nil while another PartViewer is still running a goroutine in
attemptCopy.

Here is a trace when this happens.

goroutine 76 [running]: io.copyBuffer(0x7f8ad02641d0, 0xc00040f590, 0x0,
0x0, 0xc0007cc000, 0x8000, 0x8000, 0x0, 0x0, 0x8b3d60)
/usr/lib/go/src/io/io.go:402 +0x101 io.Copy(...)
/usr/lib/go/src/io/io.go:364
git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy.func4(0xc00017efd0,
0xc0004da7c0) /home/keur/repos/aerc/widgets/msgviewer.go:576 +0x611
created by git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy
/home/keur/repos/aerc/widgets/msgviewer.go:544 +0x144

We could add a guard in store.FetchBodyPart to only call the callback
when msg.Part.Reader != nil, but we still get a hanging pager. Therefore
it seems more reasonable to disable this completely.

Signed-off-by: Kevin Kuehler &lt;keur@xcf.berkeley.edu&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Allowing the user to view deleted messages creates all sorts of race
conditions. The most devious race condition is pv.source can be set to a
nil while another PartViewer is still running a goroutine in
attemptCopy.

Here is a trace when this happens.

goroutine 76 [running]: io.copyBuffer(0x7f8ad02641d0, 0xc00040f590, 0x0,
0x0, 0xc0007cc000, 0x8000, 0x8000, 0x0, 0x0, 0x8b3d60)
/usr/lib/go/src/io/io.go:402 +0x101 io.Copy(...)
/usr/lib/go/src/io/io.go:364
git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy.func4(0xc00017efd0,
0xc0004da7c0) /home/keur/repos/aerc/widgets/msgviewer.go:576 +0x611
created by git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy
/home/keur/repos/aerc/widgets/msgviewer.go:544 +0x144

We could add a guard in store.FetchBodyPart to only call the callback
when msg.Part.Reader != nil, but we still get a hanging pager. Therefore
it seems more reasonable to disable this completely.

Signed-off-by: Kevin Kuehler &lt;keur@xcf.berkeley.edu&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Templates with Parsing</title>
<updated>2019-11-10T15:15:49+00:00</updated>
<author>
<name>Srivathsan Murali</name>
<email>sri@vathsan.com</email>
</author>
<published>2019-11-03T12:51:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=3ba69edab5f0c787424dac9649e43a7743da13ca'/>
<id>3ba69edab5f0c787424dac9649e43a7743da13ca</id>
<content type='text'>
+ Changes NewComposer to return error.
+ Add lib to handle templates using "text/template".
+ Add -T option to following commands
    - compose.
    - reply
    - forward
+ Quoted replies using templates.
+ Forwards as body using templates
+ Default templates are installed similar to filters.
+ Templates Config in aerc.conf.
    - Required templates are parsed while loading config.
+ Add aerc-templates.7 manual for using template data.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
+ Changes NewComposer to return error.
+ Add lib to handle templates using "text/template".
+ Add -T option to following commands
    - compose.
    - reply
    - forward
+ Quoted replies using templates.
+ Forwards as body using templates
+ Default templates are installed similar to filters.
+ Templates Config in aerc.conf.
    - Required templates are parsed while loading config.
+ Add aerc-templates.7 manual for using template data.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for AUTH LOGIN submission</title>
<updated>2019-11-01T15:02:01+00:00</updated>
<author>
<name>Luke Drummond</name>
<email>luke.drummond@codeplay.com</email>
</author>
<published>2019-10-29T17:11:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=331b915139e23073aa42bf28d67901383dd859ca'/>
<id>331b915139e23073aa42bf28d67901383dd859ca</id>
<content type='text'>
`go-sasl` upstream added support [1] for the obsolete [2] AUTH LOGIN
method which enables aerc to send email via servers which remain common
in the wild.

Fixes ~sircmpwn/aerc2#263

[1] https://github.com/emersion/go-sasl/commit/61afe53d
[2] https://datatracker.ietf.org/doc/draft-murchison-sasl-login/
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`go-sasl` upstream added support [1] for the obsolete [2] AUTH LOGIN
method which enables aerc to send email via servers which remain common
in the wild.

Fixes ~sircmpwn/aerc2#263

[1] https://github.com/emersion/go-sasl/commit/61afe53d
[2] https://datatracker.ietf.org/doc/draft-murchison-sasl-login/
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup pager processes after closing a msgviewer</title>
<updated>2019-10-16T15:13:53+00:00</updated>
<author>
<name>Kevin Kuehler</name>
<email>keur@xcf.berkeley.edu</email>
</author>
<published>2019-10-15T09:01:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=be4ea0d96b8cc70becb94f2d4e5abe41dea58f3a'/>
<id>be4ea0d96b8cc70becb94f2d4e5abe41dea58f3a</id>
<content type='text'>
A pager is spawned every time an email is viewed but not killed off when
quitting the msgviewer, thus leading to process leakage. This patch
fixes this by adding a Close method to the msgview widget, which is
called in the close command.

Signed-off-by: Kevin Kuehler &lt;keur@xcf.berkeley.edu&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A pager is spawned every time an email is viewed but not killed off when
quitting the msgviewer, thus leading to process leakage. This patch
fixes this by adding a Close method to the msgview widget, which is
called in the close command.

Signed-off-by: Kevin Kuehler &lt;keur@xcf.berkeley.edu&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Config for deleting message from message viewer</title>
<updated>2019-09-20T19:23:45+00:00</updated>
<author>
<name>Srivathsan Murali</name>
<email>sri@vathsan.com</email>
</author>
<published>2019-09-20T19:22:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=1bedb8fe06dd71b4ee044098b7f057b3bffd0efc'/>
<id>1bedb8fe06dd71b4ee044098b7f057b3bffd0efc</id>
<content type='text'>
As suggested in #268, this adds a behaviour setting for
deleting message from message viewer.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As suggested in #268, this adds a behaviour setting for
deleting message from message viewer.
</pre>
</div>
</content>
</entry>
<entry>
<title>Sort path completions</title>
<updated>2019-09-20T19:07:05+00:00</updated>
<author>
<name>Jeffas</name>
<email>dev@jeffas.io</email>
</author>
<published>2019-09-20T16:38:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=043a02d99d93441021788891d3f86c6fdeea22f0'/>
<id>043a02d99d93441021788891d3f86c6fdeea22f0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Make commands join args with spaces</title>
<updated>2019-09-20T19:06:34+00:00</updated>
<author>
<name>Jeffas</name>
<email>dev@jeffas.io</email>
</author>
<published>2019-09-20T16:16:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=39307a6fa7e96641b822ed0a9acb75021dcf7fe9'/>
<id>39307a6fa7e96641b822ed0a9acb75021dcf7fe9</id>
<content type='text'>
This patch ensures the following commands join their arguments with
spaces to make it easier to interact with:

- cf
- mkdir
- cd
- attach
- detach
- ct
- copy
- move
- save
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch ensures the following commands join their arguments with
spaces to make it easier to interact with:

- cf
- mkdir
- cd
- attach
- detach
- ct
- copy
- move
- save
</pre>
</div>
</content>
</entry>
<entry>
<title>Add sorting functionality</title>
<updated>2019-09-20T18:56:02+00:00</updated>
<author>
<name>Jeffas</name>
<email>dev@jeffas.io</email>
</author>
<published>2019-09-19T22:37:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=90d26da58a4af2d34328f5916adf3781222966c6'/>
<id>90d26da58a4af2d34328f5916adf3781222966c6</id>
<content type='text'>
There is a command and config option. The criteria are a list of the
sort criterion and each can be individually reversed.

This only includes support for sorting in the maildir backend currently.
The other backends are not supported in this patch.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There is a command and config option. The criteria are a list of the
sort criterion and each can be individually reversed.

This only includes support for sorting in the maildir backend currently.
The other backends are not supported in this patch.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add completion for copy</title>
<updated>2019-09-13T03:42:14+00:00</updated>
<author>
<name>Jeffas</name>
<email>dev@jeffas.io</email>
</author>
<published>2019-09-12T11:01:16+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=ad0d6319dd751ffc7bf6b2044fc673d04f9d6029'/>
<id>ad0d6319dd751ffc7bf6b2044fc673d04f9d6029</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add signatures</title>
<updated>2019-09-12T20:18:34+00:00</updated>
<author>
<name>Jeffas</name>
<email>dev@jeffas.io</email>
</author>
<published>2019-09-11T19:28:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.benburwell.com/mirrors/aerc/commit/?id=e2d5c456dc27f958d79fdf740c7b0852b2af4160'/>
<id>e2d5c456dc27f958d79fdf740c7b0852b2af4160</id>
<content type='text'>
This adds the ability for per-account signatures in the accounts.conf
config file. The signature is added to emails in the editor at the
bottom of the email. This includes when forwarding, replying to, and
composing emails.

There are two config options: signature-file and signature-cmd. The
former allows a signature to be read from a file and the latter allows
an arbitrary command to be executed to return the signature.

The config options have been documented in aerc-config
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds the ability for per-account signatures in the accounts.conf
config file. The signature is added to emails in the editor at the
bottom of the email. This includes when forwarding, replying to, and
composing emails.

There are two config options: signature-file and signature-cmd. The
former allows a signature to be read from a file and the latter allows
an arbitrary command to be executed to return the signature.

The config options have been documented in aerc-config
</pre>
</div>
</content>
</entry>
</feed>
