aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-17Remove debug loggingDrew DeVault
2019-05-17Refactor STARTTLS to prevent downgrade attacksDrew DeVault
2019-05-17Fix date header on outgoing emailsDrew DeVault
2019-05-16s/Sent/Message sent/Drew DeVault
2019-05-16Abort if accounts.conf is world readableReto Brunner
Fixes #32
2019-05-16Revert "Abort if accounts.conf is world readable"Drew DeVault
This reverts commit a755608ef9d5893b68dc4c774bbda06503481552.
2019-05-16Revert "s/aerc.conf/address.conf/ in permission check"Drew DeVault
This reverts commit 66ba099ca0bfa83cd050050d92663ec45da20141.
2019-05-16s/aerc.conf/address.conf/ in permission checkCole Helbling
Small typo in a recent commit: should abort if accounts.conf is world readable, not aerc.conf.
2019-05-16Fix issues with OOB uidsDrew DeVault
2019-05-16Abort if accounts.conf is world readableReto Brunner
Fixes #32
2019-05-16Improve reply-all recipient enumeration strategyDrew DeVault
2019-05-16Decode email when reading it for quotingDrew DeVault
2019-05-16Change default bindings for repliesDrew DeVault
2019-05-16Don't prefix Re: if prefix already presentDrew DeVault
2019-05-16Change default reply keybindingsDrew DeVault
2019-05-16Implement :reply -q and :reply -aDrew DeVault
2019-05-16Implement (basic form) of :replyDrew DeVault
2019-05-16Let caller pass in custom headers to composeDrew DeVault
2019-05-15Copy sent emails to the Sent folderDrew DeVault
Or rather, to a user-specified folder
2019-05-14Fix default bindings for quit and editDrew DeVault
2019-05-14Move ! bind to [messages]Drew DeVault
2019-05-14Add (non-functional) reply commands to bindingsDrew DeVault
2019-05-14Add ! to default keybindingsDrew DeVault
2019-05-14Implement move, mv commandsDrew DeVault
2019-05-14Force INBOX to be included in dirlistDrew DeVault
2019-05-14Implement :copy (aka :cp)Drew DeVault
2019-05-14Implement abort commandCole Helbling
This allows the user to close the compose tab without sending their current composition.
2019-05-14Update tab name as subject changesDrew DeVault
Also moves truncation to the tab widget
2019-05-14Add $EDITOR, internal config for composeDrew DeVault
2019-05-14Add IRC link to README.mdDrew DeVault
2019-05-14Remove tab before going asyncDrew DeVault
To prevent repeated attempts to send
2019-05-14Add distinct keybindings for each compose viewDrew DeVault
2019-05-14Send emails asyncronouslyDrew DeVault
2019-05-14Implement sending emails /o/Drew DeVault
2019-05-14Add :send-message, prepares & writes email to /tmpDrew DeVault
2019-05-13Remove leftover debug loggingDrew DeVault
2019-05-13Handle external message deletionsDrew DeVault
2019-05-13Handle incoming emails gracefullyDrew DeVault
2019-05-13Spec out review message screenDrew DeVault
2019-05-13Populate "From" header from config for new emailsDrew DeVault
2019-05-12Add outgoing account configurationDrew DeVault
2019-05-12Implement :{next,prev}-field in compose viewDrew DeVault
2019-05-12Expand compose focus handling a bitDrew DeVault
2019-05-12Add initial compose widgetDrew DeVault
2019-05-11Move aerc to dedicated mailing listDrew DeVault
2019-05-11"Press any key to close" for completed processesDrew DeVault
2019-05-11Refactor ctx stashing out of exlineDrew DeVault
2019-05-11Split ex line text handling into dedicated widgetDrew DeVault
2019-05-05lib/ui: fix UI.Exit race conditionSimon Ser
UI.Exit can be accessed from goroutines drawing, goroutines executing commands and goroutines waiting for events. Write at 0x00c0002b2040 by main goroutine: main.main.func1() /home/simon/src/aerc2/aerc.go:76 +0x33d git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).BeginExCommand.func1() /home/simon/src/aerc2/widgets/aerc.go:245 +0x89 git.sr.ht/~sircmpwn/aerc2/widgets.(*ExLine).Event() /home/simon/src/aerc2/widgets/exline.go:131 +0x442 git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).Event() /home/simon/src/aerc2/widgets/aerc.go:116 +0x83c git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).simulate() /home/simon/src/aerc2/widgets/aerc.go:109 +0x12a git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).Event() /home/simon/src/aerc2/widgets/aerc.go:142 +0x722 git.sr.ht/~sircmpwn/aerc2/lib/ui.(*UI).Tick() /home/simon/src/aerc2/lib/ui/ui.go:75 +0x33f main.main() /home/simon/src/aerc2/aerc.go:94 +0x497 Previous read at 0x00c0002b2040 by goroutine 19: git.sr.ht/~sircmpwn/aerc2/lib/ui.Initialize.func1() /home/simon/src/aerc2/lib/ui/ui.go:45 +0x97 Goroutine 19 (running) created at: git.sr.ht/~sircmpwn/aerc2/lib/ui.Initialize() /home/simon/src/aerc2/lib/ui/ui.go:44 +0x372 main.main() /home/simon/src/aerc2/aerc.go:87 +0x3a9
2019-05-05lib/ui: fix Grid race conditionSimon Ser
This was is more complicated than others. The cells list is accessed by multiple goroutines: - Some change the Grid's contents via AddChild/RemoveChild - Some call Draw - Some invalidate the grid via Invalidate Invalidate calls are tricky to handle because they will also invalidate all child cells. This will inturn trigger the cellInvalidated callback, which needs to read the list of cells. For this reason, we use a sync.RWLock which allows multiple concurrent reads. Below is the race fixed by this commit. Read at 0x00c0000bc3d0 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/lib/ui.(*Grid).cellInvalidated() /home/simon/src/aerc2/lib/ui/grid.go:181 +0x45 git.sr.ht/~sircmpwn/aerc2/lib/ui.(*Grid).cellInvalidated-fm() /home/simon/src/aerc2/lib/ui/grid.go:179 +0x55 git.sr.ht/~sircmpwn/aerc2/lib/ui.(*Invalidatable).DoInvalidate() /home/simon/src/aerc2/lib/ui/invalidatable.go:22 +0x85 git.sr.ht/~sircmpwn/aerc2/lib/ui.(*Bordered).contentInvalidated-fm() /home/simon/src/aerc2/lib/ui/borders.go:39 +0x56 git.sr.ht/~sircmpwn/aerc2/lib/ui.(*Invalidatable).DoInvalidate() /home/simon/src/aerc2/lib/ui/invalidatable.go:22 +0x85 git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:81 +0x55 git.sr.ht/~sircmpwn/aerc2/lib/ui.(*Invalidatable).DoInvalidate() /home/simon/src/aerc2/lib/ui/invalidatable.go:22 +0x85 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:88 +0x82 Previous write at 0x00c0000bc3d0 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x98 git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x28b git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:49 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x807 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 09:44:25 +0000