Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-05-19 | Update internal state and draw from the same goroutine | Simon Ser | |
This commit introduces a new Aerc.Tick function that should be called to refresh the internal state. This in turn makes each AccountView process worker events. The UI goroutine repeatedly refreshes the internal state before drawing a new frame. The reason for this is that many worker messages may need to be processed for a single frame, and drawing the UI is far slower than refreshing the internal state. This has been confirmed in my testing (calling Aerc.Tick only once per frame results in a slower display). Many synchronization code has been removed. We can now write widgets without having to care so much about races. The remaining sync users are: - widgets/spinner: the spinner value is updated from inside an internal goroutine - lib/ui/invalidatable: Invalidate may be called from any goroutine - lib/ui/grid: same - lib/ui/ui: an internal goroutine needs read access to UI.exit - worker/types/worker: Worker.callbacks is used for both worker and UI callbacks The exact goroutine requirements for Drawable have been documented. | |||
2019-05-17 | s/aerc2/aerc/g | Drew DeVault | |
2019-05-17 | Remove unimplemented color configuration | Drew DeVault | |
Will probably end up doing this differently anyway | |||
2019-05-16 | Implement (basic form) of :reply | Drew DeVault | |
2019-05-14 | Implement :copy (aka :cp) | Drew DeVault | |
2019-05-13 | Handle incoming emails gracefully | Drew DeVault | |
2019-05-13 | Populate "From" header from config for new emails | Drew DeVault | |
2019-04-27 | lib/ui: introduce Invalidatable | Simon Ser | |
Many Drawable implementations have their own Invalidate and OnInvalidate functions, with an unexported onInvalidate field. However OnInvalidate and Invalidate are usually not called in the same goroutine. This results in a race on this field, e.g.: Read at 0x00c000094748 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:85 +0x56 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:93 +0x1bb Previous write at 0x00c000094748 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x8f git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e To fix this, introduce a new type, Invalidatable, which protects the field. Unfortunately the Drawable must be passed to the callback function in Invalidate, so we still need to re-implement this in each Invalidatable user. | |||
2019-03-31 | Make message viewer real, part two | Drew DeVault | |
2019-03-30 | Correct color of error messages | Drew DeVault | |
2019-03-29 | Add body fetching support code | Drew DeVault | |
2019-03-20 | Implement :delete-message | Drew DeVault | |
2019-03-17 | Move exline handling up to aerc, add :term | Drew DeVault | |
2019-03-17 | Add basic terminal widget | Drew DeVault | |
2019-03-15 | Move MessageStore into its own file | Drew DeVault | |
2019-03-15 | Implement default in accounts.conf | Drew DeVault | |
2019-03-15 | Implement sidebar-width config option | Drew DeVault | |
2019-03-15 | Rig up key bindings | Drew DeVault | |
2019-03-14 | Implement :{next,prev}-message | Drew DeVault | |
2019-03-14 | Use cached message store when re-opening dirs | Drew DeVault | |
2019-03-14 | Implement :cd command | Drew DeVault | |
2019-03-14 | Implement message store side of message fetching | Drew DeVault | |
2019-03-14 | Lay out message list widget basic design | Drew DeVault | |
2019-03-10 | Fetch valid UIDs from server after opening dir | Drew DeVault | |
2019-03-10 | Improve error reporting | Drew DeVault | |
2019-03-10 | Flesh out command parsing & handling | Drew DeVault | |
2019-03-10 | Start building out command subsystem | Drew DeVault | |
2019-02-10 | Fix build | Elias Naur | |
2019-01-20 | Implement Container interface in widgets/ | Drew DeVault | |
2019-01-14 | Send commands up to the top-level aerc widget | Drew DeVault | |
2019-01-13 | Handle errors from worker initialization | Drew DeVault | |
2019-01-13 | Swap message list placeholder for spinner | Drew DeVault | |
2019-01-13 | Handle connection errors properly | Drew DeVault | |
2019-01-13 | Simplify approach to directory list | Drew DeVault | |
This doesn't really need to be abstract tbh | |||
2019-01-13 | Filter dirlist according to user config | Drew DeVault | |
2019-01-13 | Add directory list widget | Drew DeVault | |
2019-01-13 | Move ex line into account | Drew DeVault | |
2019-01-13 | Move status line into account, update behavior | Drew DeVault | |
2019-01-13 | Initialize worker in account widget | Drew DeVault | |
2019-01-13 | Add basic account widget, populate real acct views | Drew DeVault | |