Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-05-20 | Show attachment names in multipart view | Drew DeVault | |
2019-05-20 | Implement :next-part, :prev-part | Drew DeVault | |
2019-05-20 | Flesh out multipart switcher | Drew DeVault | |
2019-05-20 | Refactor message part into dedicated widget | Drew DeVault | |
2019-05-17 | s/aerc2/aerc/g | Drew DeVault | |
2019-05-14 | Add :send-message, prepares & writes email to /tmp | Drew DeVault | |
2019-04-27 | lib/ui: introduce Invalidatable | Simon Ser | |
Many Drawable implementations have their own Invalidate and OnInvalidate functions, with an unexported onInvalidate field. However OnInvalidate and Invalidate are usually not called in the same goroutine. This results in a race on this field, e.g.: Read at 0x00c000094748 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:85 +0x56 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:93 +0x1bb Previous write at 0x00c000094748 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x8f git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e To fix this, introduce a new type, Invalidatable, which protects the field. Unfortunately the Drawable must be passed to the callback function in Invalidate, so we still need to re-implement this in each Invalidatable user. | |||
2019-04-07 | Lowercase MIME types while matching filters | Gokberk Yaltirakli | |
2019-03-31 | Remove extra debug statement | Drew DeVault | |
2019-03-31 | Use shell to execute filters, fix non-determinism | Drew DeVault | |
2019-03-31 | Implement header-regex-match filters | Drew DeVault | |
2019-03-31 | Improve error handling in message viewer | Drew DeVault | |
Still not great but at least it tells you when something went wrong | |||
2019-03-31 | Add basic filter implementation | Drew DeVault | |
2019-03-31 | Decode messages before rendering them | Drew DeVault | |
2019-03-31 | Make message viewer real, part two | Drew DeVault | |
2019-03-31 | Make the message viewer real, part one | Drew DeVault | |
2019-03-30 | Minor refactoring to header view | Drew DeVault | |
2019-03-30 | Use bold instead of inverted for header names | Drew DeVault | |
2019-03-30 | Add multipart selector mockup to msgviewer | Drew DeVault | |
2019-03-30 | Add basic message viewer mockup | Drew DeVault | |