Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-05-11 | "Press any key to close" for completed processes | Drew DeVault | |
2019-05-11 | Refactor ctx stashing out of exline | Drew DeVault | |
2019-05-11 | Split ex line text handling into dedicated widget | Drew DeVault | |
2019-04-29 | lib/msgstore: protect with a mutex | Simon Ser | |
MessageStore has a lot of exported fields that can be read from the outside. Each read must be protected, because a call from Update could happen at any time. | |||
2019-04-29 | widgets/msglist: fix MessageList.store race | Simon Ser | |
This field could be written to in the middle of a Draw call, which reads it multiple times. Use an atomic variable instead. | |||
2019-04-27 | lib/ui: introduce Invalidatable | Simon Ser | |
Many Drawable implementations have their own Invalidate and OnInvalidate functions, with an unexported onInvalidate field. However OnInvalidate and Invalidate are usually not called in the same goroutine. This results in a race on this field, e.g.: Read at 0x00c000094748 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:85 +0x56 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:93 +0x1bb Previous write at 0x00c000094748 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x8f git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e To fix this, introduce a new type, Invalidatable, which protects the field. Unfortunately the Drawable must be passed to the callback function in Invalidate, so we still need to re-implement this in each Invalidatable user. | |||
2019-04-27 | widgets/spinner: fix Spinner.frame race | Simon Ser | |
It's accessed by the goroutine which increments it and the goroutine that draws the widget at the same time. Use atomic instead. Write at 0x00c00000ebc0 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:50 +0x169 Previous read at 0x00c00000ebc0 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:44 +0x8b git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e | |||
2019-04-15 | Re-render terminal on invalidate | Drew DeVault | |
2019-04-10 | Fix segfault on :view-message for unloaded message | Tom Lebreux | |
This also fixes segfault on :view-message on empty directory Signed-off-by: Tom Lebreux <tomlebreux@cock.li> | |||
2019-04-07 | Lowercase MIME types while matching filters | Gokberk Yaltirakli | |
2019-04-05 | Clear damage on each terminal.Draw call | Drew DeVault | |
2019-04-05 | Fix wrong row due to typo | Tom Lebreux | |
Signed-off-by: Tom Lebreux <tomlebreux@cock.li> | |||
2019-04-05 | Fix infinite loop on empty DirectoryContents | Tom Lebreux | |
When changing to an empty directory, ml.selected is 0, and the length of ml.store.Uids is 0. The loop condition is always true so we have an infinite loop causing 100% CPU usage and prevents us to change to other directories. Signed-off-by: Tom Lebreux <tomlebreux@cock.li> | |||
2019-04-04 | Show (no messages) for empty folders | Drew DeVault | |
2019-03-31 | Remove extra debug statement | Drew DeVault | |
2019-03-31 | Use shell to execute filters, fix non-determinism | Drew DeVault | |
2019-03-31 | Implement header-regex-match filters | Drew DeVault | |
2019-03-31 | Improve error handling in message viewer | Drew DeVault | |
Still not great but at least it tells you when something went wrong | |||
2019-03-31 | Add basic filter implementation | Drew DeVault | |
2019-03-31 | Decode messages before rendering them | Drew DeVault | |
2019-03-31 | Make message viewer real, part two | Drew DeVault | |
2019-03-31 | Make the message viewer real, part one | Drew DeVault | |
2019-03-30 | Add message view commands, :close | Drew DeVault | |
2019-03-30 | Minor refactoring to header view | Drew DeVault | |
2019-03-30 | Fix crash on command not found | Drew DeVault | |
2019-03-30 | Use bold instead of inverted for header names | Drew DeVault | |
2019-03-30 | Add multipart selector mockup to msgviewer | Drew DeVault | |
2019-03-30 | Add basic message viewer mockup | Drew DeVault | |
2019-03-30 | Correct color of error messages | Drew DeVault | |
2019-03-30 | Use tcell.Style.Reverse instead of black on white | Drew DeVault | |
2019-03-30 | Implement :pipe | Drew DeVault | |
2019-03-30 | Show deleted emails pending server ack in grey | Drew DeVault | |
TODO: Don't let the user select or interact with deleted messages | |||
2019-03-29 | Add body fetching support code | Drew DeVault | |
2019-03-21 | Expire status errors on input | Drew DeVault | |
2019-03-21 | term: don't mess with cursor when unfocused | Drew DeVault | |
2019-03-21 | Enable alt screen on built-in terminal | Drew DeVault | |
2019-03-21 | Make terminal closure thread safe | Drew DeVault | |
2019-03-21 | Use GetCursorPos instead of stored position | Drew DeVault | |
2019-03-21 | Skip writes if term is closed | Drew DeVault | |
2019-03-21 | Improve cursor handling in embedded terminal | Drew DeVault | |
2019-03-21 | Fix cursor handling in embedded terminal | Drew DeVault | |
2019-03-21 | Forward key events to child terminal | Drew DeVault | |
2019-03-21 | Use : for keybindings even when ex is overridden | Drew DeVault | |
2019-03-21 | Rig up terminal keybinding group | Drew DeVault | |
2019-03-21 | Use user's configured ex key | Drew DeVault | |
2019-03-21 | Add context-specific keybindings | Drew DeVault | |
2019-03-20 | Implement :delete-message | Drew DeVault | |
2019-03-17 | moar colors | Drew DeVault | |
2019-03-17 | Fix scrolling issues on :select-message | Drew DeVault | |
2019-03-17 | s/:term-close/:close/g | Drew DeVault | |