From b812257ba97020e90e7598378b54f737364a1636 Mon Sep 17 00:00:00 2001 From: Reto Brunner Date: Sun, 28 Jul 2019 15:02:09 +0200 Subject: Print errors from config load issues. Currently we /dev/null stdout, if it is a tty. The checkConfigPerms function, as well as the error print were incorrectly writing to stdout and therefore weren't visible to most users. --- config/config.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'config') diff --git a/config/config.go b/config/config.go index 356d562..8ba705c 100644 --- a/config/config.go +++ b/config/config.go @@ -465,9 +465,9 @@ func checkConfigPerms(filename string) error { goPerms := perms >> 3 // group or others have read access if goPerms&0x44 != 0 { - fmt.Printf("The file %v has too open permissions.\n", filename) - fmt.Println("This is a security issue (it contains passwords).") - fmt.Printf("To fix it, run `chmod 600 %v`\n", filename) + fmt.Fprintf(os.Stderr, "The file %v has too open permissions.\n", filename) + fmt.Fprintln(os.Stderr, "This is a security issue (it contains passwords).") + fmt.Fprintf(os.Stderr, "To fix it, run `chmod 600 %v`\n", filename) return errors.New("account.conf permissions too lax") } return nil -- cgit v1.2.3