diff options
Diffstat (limited to 'server/auth/github')
-rw-r--r-- | server/auth/github/github.go | 2 | ||||
-rw-r--r-- | server/auth/github/github_test.go | 8 |
2 files changed, 4 insertions, 6 deletions
diff --git a/server/auth/github/github.go b/server/auth/github/github.go index 24a4bbf..7628526 100644 --- a/server/auth/github/github.go +++ b/server/auth/github/github.go @@ -32,7 +32,7 @@ func New(c *config.Auth) (auth.Provider, error) { uw[u] = true } if c.ProviderOpts["organization"] == "" && len(uw) == 0 { - return nil, errors.New("github_opts organization and the users whitelist must not be both empty") + return nil, errors.New("either GitHub organization or users whitelist must be specified") } return &Config{ config: &oauth2.Config{ diff --git a/server/auth/github/github_test.go b/server/auth/github/github_test.go index c0b26a4..b0c97d2 100644 --- a/server/auth/github/github_test.go +++ b/server/auth/github/github_test.go @@ -29,11 +29,9 @@ func TestNew(t *testing.T) { func TestNewEmptyOrganization(t *testing.T) { organization = "" - a := assert.New(t) - - _, err := newGithub() - a.EqualError(err, "github_opts organization and the users whitelist must not be both empty") - + if _, err := newGithub(); err == nil { + t.Error("creating a provider without an organization set should return an error") + } organization = "exampleorg" } |