From f906c9ba422eb720514721b559c01f840ca34a0c Mon Sep 17 00:00:00 2001 From: Niall Sheridan Date: Mon, 20 Aug 2018 17:18:27 +0100 Subject: Remove authprovider.Session --- server/auth/github/github.go | 6 ++---- server/auth/github/github_test.go | 6 +++--- 2 files changed, 5 insertions(+), 7 deletions(-) (limited to 'server/auth/github') diff --git a/server/auth/github/github.go b/server/auth/github/github.go index d546478..38009e1 100644 --- a/server/auth/github/github.go +++ b/server/auth/github/github.go @@ -97,10 +97,8 @@ func (c *Config) Revoke(token *oauth2.Token) error { } // StartSession retrieves an authentication endpoint from Github. -func (c *Config) StartSession(state string) *auth.Session { - return &auth.Session{ - AuthURL: c.config.AuthCodeURL(state), - } +func (c *Config) StartSession(state string) string { + return c.config.AuthCodeURL(state) } // Exchange authorizes the session and returns an access token. diff --git a/server/auth/github/github_test.go b/server/auth/github/github_test.go index 8c51f4f..9e94f9a 100644 --- a/server/auth/github/github_test.go +++ b/server/auth/github/github_test.go @@ -62,9 +62,9 @@ func TestStartSession(t *testing.T) { p, _ := newGithub() s := p.StartSession("test_state") - a.Contains(s.AuthURL, "github.com/login/oauth/authorize") - a.Contains(s.AuthURL, "state=test_state") - a.Contains(s.AuthURL, fmt.Sprintf("client_id=%s", oauthClientID)) + a.Contains(s, "github.com/login/oauth/authorize") + a.Contains(s, "state=test_state") + a.Contains(s, fmt.Sprintf("client_id=%s", oauthClientID)) } func newGithub() (*Config, error) { -- cgit v1.2.3