From 12417f0dddf4be86aa5b9a4cb25bf48a4e301086 Mon Sep 17 00:00:00 2001 From: Niall Sheridan Date: Wed, 8 Aug 2018 11:24:22 +0100 Subject: Misc fixes - Add `fast_finish` to travis config - Specify that Go 1.9 is supported - Additional error checking which was previously missed - Make the migrations test better - --- server/store/sqldb.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'server/store/sqldb.go') diff --git a/server/store/sqldb.go b/server/store/sqldb.go index b5948b7..e95f53b 100644 --- a/server/store/sqldb.go +++ b/server/store/sqldb.go @@ -108,11 +108,6 @@ func autoMigrate(driver string, conn *sqlx.DB) error { return nil } -// rowScanner is implemented by sql.Row and sql.Rows -type rowScanner interface { - Scan(dest ...interface{}) error -} - // Get a single *CertRecord func (db *sqlStore) Get(id string) (*CertRecord, error) { if err := db.conn.Ping(); err != nil { @@ -161,6 +156,10 @@ func (db *sqlStore) Revoke(ids []string) error { return errors.Wrap(err, "unable to connect to database") } q, args, err := sqlx.In("UPDATE issued_certs SET revoked = 1 WHERE key_id IN (?)", ids) + if err != nil { + return err + } + q = db.conn.Rebind(q) _, err = db.conn.Query(q, args...) return err } -- cgit v1.2.3