From 8b1ee3e95010681d98d1b31af98f0ce0832cedd2 Mon Sep 17 00:00:00 2001 From: Niall Sheridan Date: Mon, 8 Jul 2019 23:15:32 +0100 Subject: Fix revocations query and UI Use `Exec` rather than `Query` to update revoked status `Query` works with MySQL but `Exec` is needed with sqlite Test that the key is revoked Correct column ordering --- server/store/sqldb.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'server/store/sqldb.go') diff --git a/server/store/sqldb.go b/server/store/sqldb.go index de242eb..8ca34a9 100644 --- a/server/store/sqldb.go +++ b/server/store/sqldb.go @@ -145,7 +145,8 @@ func (db *sqlStore) List(includeExpired bool) ([]*CertRecord, error) { // Revoke an issued cert by id. func (db *sqlStore) Revoke(ids []string) error { - if err := db.conn.Ping(); err != nil { + var err error + if err = db.conn.Ping(); err != nil { return errors.Wrap(err, "unable to connect to database") } q, args, err := sqlx.In("UPDATE issued_certs SET revoked = 1 WHERE key_id IN (?)", ids) @@ -153,7 +154,7 @@ func (db *sqlStore) Revoke(ids []string) error { return err } q = db.conn.Rebind(q) - _, err = db.conn.Query(q, args...) + _, err = db.conn.Exec(q, args...) return err } -- cgit v1.2.3