aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJay Satiro <raysatiro@yahoo.com>2016-11-16 02:16:10 -0500
committerJay Satiro <raysatiro@yahoo.com>2016-11-16 02:16:10 -0500
commitb65f79d9e84277594f0df98ae4b997053176983d (patch)
treeb758a851bc2770418dce807e1c4e70f5b2b520d1
parent03d707fc5fe137376a0ae4e5c6fe3d918367550f (diff)
http2: Fix address sanitizer memcpy warning
- In Curl_http2_switched don't call memcpy when src is NULL. Curl_http2_switched can be called like: Curl_http2_switched(conn, NULL, 0); .. and prior to this change memcpy was then called like: memcpy(dest, NULL, 0) .. causing address sanitizer to warn: http2.c:2057:3: runtime error: null pointer passed as argument 2, which is declared to never be null
-rw-r--r--lib/http2.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/http2.c b/lib/http2.c
index 1484e1515..6720984b0 100644
--- a/lib/http2.c
+++ b/lib/http2.c
@@ -2054,7 +2054,8 @@ CURLcode Curl_http2_switched(struct connectdata *conn,
" after upgrade: len=%zu\n",
nread);
- memcpy(httpc->inbuf, mem, nread);
+ if(nread)
+ memcpy(httpc->inbuf, mem, nread);
httpc->inbuflen = nread;
nproc = nghttp2_session_mem_recv(httpc->h2, (const uint8_t *)httpc->inbuf,