aboutsummaryrefslogtreecommitdiff
path: root/CHANGES
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2009-03-09 12:21:46 +0000
committerDaniel Stenberg <daniel@haxx.se>2009-03-09 12:21:46 +0000
commitbdec6f2b20440b53859e472d185a21f1951341d5 (patch)
treee4b28569a8cd1bbc59686932e3e8c9810bb98d29 /CHANGES
parentc86c294f554b901754e8ec97ae5399b7f217b9ba (diff)
- Frank Hempel found out a bug and provided the fix:
curl_easy_duphandle did not necessarily duplicate the CURLOPT_COOKIEFILE option. It only enabled the cookie engine in the destination handle if data->cookies is not NULL (where data is the source handle). In case of a newly initialized handle which just had the cookie support enabled by a curl_easy_setopt(handle, CURL_COOKIEFILE, "")-call, handle->cookies was still NULL because the setopt-call only appends the value to data->change.cookielist, hence duplicating this handle would not have the cookie engine switched on. We also concluded that the slist-functionality would be suitable for being put in its own module rather than simply hanging out in lib/sendf.c so I created lib/slist.[ch] for them.
Diffstat (limited to 'CHANGES')
-rw-r--r--CHANGES15
1 files changed, 15 insertions, 0 deletions
diff --git a/CHANGES b/CHANGES
index c98a3f670..49a1d76ef 100644
--- a/CHANGES
+++ b/CHANGES
@@ -7,6 +7,21 @@
Changelog
Daniel Stenberg (9 Mar 2009)
+- Frank Hempel found out a bug and provided the fix:
+
+ curl_easy_duphandle did not necessarily duplicate the CURLOPT_COOKIEFILE
+ option. It only enabled the cookie engine in the destination handle if
+ data->cookies is not NULL (where data is the source handle). In case of a
+ newly initialized handle which just had the cookie support enabled by a
+ curl_easy_setopt(handle, CURL_COOKIEFILE, "")-call, handle->cookies was
+ still NULL because the setopt-call only appends the value to
+ data->change.cookielist, hence duplicating this handle would not have the
+ cookie engine switched on.
+
+ We also concluded that the slist-functionality would be suitable for being
+ put in its own module rather than simply hanging out in lib/sendf.c so I
+ created lib/slist.[ch] for them.
+
- Andreas Farber made the 'buildconf' script check for the presence of m4
scripts to make it detect a bad checkout earlier. People with older
checkouts who don't do cvs update with the -d option won't get the new dirs