aboutsummaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2017-06-22 10:31:03 +0200
committerDaniel Stenberg <daniel@haxx.se>2017-06-22 10:31:03 +0200
commitb4043706eba8436cf82815277af9153c687757c7 (patch)
tree365d899673a546acfadf32c98fec73fd56e149e1 /docs
parent0537238cbf9e731a1dcb864bbf4b2093e2c51703 (diff)
CONTRIBUTE.md: mention the out-of-tree build test too
Diffstat (limited to 'docs')
-rw-r--r--docs/CONTRIBUTE.md11
1 files changed, 6 insertions, 5 deletions
diff --git a/docs/CONTRIBUTE.md b/docs/CONTRIBUTE.md
index 7d3c2e073..536a9ceb3 100644
--- a/docs/CONTRIBUTE.md
+++ b/docs/CONTRIBUTE.md
@@ -157,14 +157,15 @@ lists.
Every pull request submitted will automatically be tested in several different
ways. Every pull request is verfied that:
- - ... the code still builds, warning-free, on Linux and macOS, with both
+ - ... it still builds, warning-free, on Linux and macOS, with both
clang and gcc
- - ... the code still builds fine on Windows with several MSVC versions
- - ... the code still builds with cmake on Linux, with gcc and clang
- - ... the code follows rudimentary code style rules
+ - ... it still builds fine on Windows with several MSVC versions
+ - ... it still builds with cmake on Linux, with gcc and clang
+ - ... it follows rudimentary code style rules
- ... the test suite still runs 100% fine
- ... the release tarball (the "dist") still works
- - ... the code coverage doesn't shrink drastically
+ - ... it builds fine in-tree as well as out-of-tree
+ - ... code coverage doesn't shrink drastically
If the pull-request fails one of these tests, it will show up as a red X and
you are expected to fix the problem. If you don't understand whan the issue is