diff options
author | Mike Giancola <mikegiancola@gmail.com> | 2013-05-22 23:08:27 +0200 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2013-05-22 23:08:27 +0200 |
commit | e58d9c87f783334b01310260e0cf5220c338c58c (patch) | |
tree | 9f480c36c4adb0dfe57e1c3485d810b5c483ae51 /lib/curl_setup_once.h | |
parent | 84f799147431a15d1efc86654950408120adad22 (diff) |
ossl_send: SSL_write() returning 0 is an error too
We found that in specific cases if the connection is abruptly closed,
the underlying socket is listed in a close_wait state. We continue to
call the curl_multi_perform, curl_mutli_fdset etc. None of these APIs
report the socket closed / connection finished. Since we have cases
where the multi connection is only used once, this can pose a problem
for us. I've read that if another connection was to come in, curl would
see the socket as bad and attempt to close it at that time -
unfortunately, this does not work for us.
I found that in specific situations, if SSL_write returns 0, curl did
not recognize the socket as closed (or errored out) and did not report
it to the application. I believe we need to change the code slightly, to
check if ssl_write returns 0. If so, treat it as an error - the same as
a negative return code.
For OpenSSL - the ssl_write documentation is here:
http://www.openssl.org/docs/ssl/SSL_write.html
Diffstat (limited to 'lib/curl_setup_once.h')
0 files changed, 0 insertions, 0 deletions