diff options
| author | Marcel Raad <Marcel.Raad@teamviewer.com> | 2019-05-25 10:06:08 +0200 |
|---|---|---|
| committer | Marcel Raad <Marcel.Raad@teamviewer.com> | 2019-06-05 20:38:06 +0200 |
| commit | e23c52b3295a525fbaae9e7ed3e7061fea6dffc2 (patch) | |
| tree | 4a74cf5ed3496a6126f1cc7c4284b6620108db06 /lib/vtls | |
| parent | 04ac54e1965041684fc1b6532eba90f58601264e (diff) | |
build: fix Codacy warnings
Reduce variable scopes and remove redundant variable stores.
Closes https://github.com/curl/curl/pull/3975
Diffstat (limited to 'lib/vtls')
| -rw-r--r-- | lib/vtls/cyassl.c | 5 | ||||
| -rw-r--r-- | lib/vtls/mesalink.c | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/lib/vtls/cyassl.c b/lib/vtls/cyassl.c index 44a2bdda6..40626a5f1 100644 --- a/lib/vtls/cyassl.c +++ b/lib/vtls/cyassl.c @@ -357,9 +357,8 @@ cyassl_connect_step1(struct connectdata *conn, /* give application a chance to interfere with SSL set up. */ if(data->set.ssl.fsslctx) { - CURLcode result = CURLE_OK; - result = (*data->set.ssl.fsslctx)(data, BACKEND->ctx, - data->set.ssl.fsslctxp); + CURLcode result = (*data->set.ssl.fsslctx)(data, BACKEND->ctx, + data->set.ssl.fsslctxp); if(result) { failf(data, "error signaled by ssl ctx callback"); return result; diff --git a/lib/vtls/mesalink.c b/lib/vtls/mesalink.c index 718c282ee..7ca4f0eac 100644 --- a/lib/vtls/mesalink.c +++ b/lib/vtls/mesalink.c @@ -265,7 +265,6 @@ mesalink_connect_step2(struct connectdata *conn, int sockindex) ret = SSL_connect(BACKEND->handle); if(ret != SSL_SUCCESS) { - char error_buffer[MESALINK_MAX_ERROR_SZ]; int detail = SSL_get_error(BACKEND->handle, ret); if(SSL_ERROR_WANT_CONNECT == detail || SSL_ERROR_WANT_READ == detail) { @@ -273,6 +272,7 @@ mesalink_connect_step2(struct connectdata *conn, int sockindex) return CURLE_OK; } else { + char error_buffer[MESALINK_MAX_ERROR_SZ]; failf(data, "SSL_connect failed with error %d: %s", detail, |