diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2017-11-04 16:42:21 +0100 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2017-11-04 22:22:49 +0100 |
| commit | 685ef130575cdcf63fe9547757d88a49a40ef281 (patch) | |
| tree | d3c1f4f281c61a4ea7aaff2a05da6e1df71276c5 /lib | |
| parent | d2146c598aa8f9746af55f133a6017b4fe541f7c (diff) | |
ntlm: avoid malloc(0) for zero length passwords
It triggers an assert() when built with memdebug since malloc(0) may
return NULL *or* a valid pointer.
Detected by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4054
Assisted-by: Max Dymond
Closes #2054
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/curl_ntlm_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/curl_ntlm_core.c b/lib/curl_ntlm_core.c index 5154949e6..1309bf0d9 100644 --- a/lib/curl_ntlm_core.c +++ b/lib/curl_ntlm_core.c @@ -557,7 +557,7 @@ CURLcode Curl_ntlm_core_mk_nt_hash(struct Curl_easy *data, unsigned char *ntbuffer /* 21 bytes */) { size_t len = strlen(password); - unsigned char *pw = malloc(len * 2); + unsigned char *pw = len ? malloc(len * 2) : strdup(""); CURLcode result; if(!pw) return CURLE_OUT_OF_MEMORY; |