aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2014-10-08 12:21:39 +0200
committerDaniel Stenberg <daniel@haxx.se>2014-10-08 12:21:39 +0200
commit987a4a7367ac8df32628ba738342e2206582f1e7 (patch)
treebd83a31ce739c25f8e8360aff2491714b70aef9a /src
parente0d269c0d8da074ad59aca87b291c7f8146df574 (diff)
operate_do: skip superfluous check for NULL pointer
Coverity CID 1243583. get_url_file_name() cannot fail and return a NULL file name pointer so skip the check for that - it tricks coverity into believing it can happen and it then warns later on when we use 'outfile' without checking for NULL.
Diffstat (limited to 'src')
-rw-r--r--src/tool_operate.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tool_operate.c b/src/tool_operate.c
index 488fb08c4..7448cad9c 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -543,7 +543,7 @@ static CURLcode operate_do(struct GlobalConfig *global,
res = get_url_file_name(&outfile, this_url);
if(res)
goto show_error;
- if((!outfile || !*outfile) && !config->content_disposition) {
+ if(!*outfile && !config->content_disposition) {
helpf(global->errors, "Remote file name has no length!\n");
res = CURLE_WRITE_ERROR;
goto quit_urls;