diff options
author | Daniel Stenberg <daniel@haxx.se> | 2015-11-24 09:32:42 +0100 |
---|---|---|
committer | Daniel Stenberg <daniel@haxx.se> | 2015-11-24 09:36:45 +0100 |
commit | c341311a0e875f4fc5229721c2f6ef19414f514e (patch) | |
tree | 910cbae630ca12c3e9da147c31d667425a0337eb /src | |
parent | fc5d783589268b7ee66a80173c48e940015b1787 (diff) |
Revert "cleanup: general removal of TODO (and similar) comments"
This reverts commit 64e959ffe37c436503f9fed1ce2d6ee6ae50bd9a.
Feedback-by: Dan Fandrich
URL: http://curl.haxx.se/mail/lib-2015-11/0062.html
Diffstat (limited to 'src')
-rw-r--r-- | src/tool_cb_prg.c | 10 | ||||
-rw-r--r-- | src/tool_operate.c | 12 |
2 files changed, 19 insertions, 3 deletions
diff --git a/src/tool_cb_prg.c b/src/tool_cb_prg.c index e6ec032ab..9e3c5fb4e 100644 --- a/src/tool_cb_prg.c +++ b/src/tool_cb_prg.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al. + * Copyright (C) 1998 - 2014, Daniel Stenberg, <daniel@haxx.se>, et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -117,8 +117,11 @@ void progressbarinit(struct ProgressData *bar, if(config->use_resume) bar->initial_size = config->resume_from; +/* TODO: get terminal width through ansi escapes or something similar. + try to update width when xterm is resized... - 19990617 larsa */ #ifndef __EMX__ - /* OS/2 users most likely won't have this env var set, and besides that + /* 20000318 mgs + * OS/2 users most likely won't have this env var set, and besides that * we're using our own way to determine screen width */ colp = curlx_getenv("COLUMNS"); if(colp) { @@ -133,7 +136,8 @@ void progressbarinit(struct ProgressData *bar, else bar->width = 79; #else - /* We use this emx library call to get the screen width, and subtract + /* 20000318 mgs + * We use this emx library call to get the screen width, and subtract * one from what we got in order to avoid a problem with the cursor * advancing to the next line if we print a string that is as long as * the screen is wide. */ diff --git a/src/tool_operate.c b/src/tool_operate.c index b84b54c39..66ab0fabb 100644 --- a/src/tool_operate.c +++ b/src/tool_operate.c @@ -116,6 +116,7 @@ CURLcode curl_easy_perform_ev(CURL *easy); static bool is_fatal_error(CURLcode code) { switch(code) { + /* TODO: Should CURLE_SSL_CACERT be included as critical error ? */ case CURLE_FAILED_INIT: case CURLE_OUT_OF_MEMORY: case CURLE_UNKNOWN_OPTION: @@ -855,6 +856,8 @@ static CURLcode operate_do(struct GlobalConfig *global, #if !defined(CURL_DISABLE_PROXY) { + /* TODO: Make this a run-time check instead of compile-time one. */ + my_setopt_str(curl, CURLOPT_PROXY, config->proxy); my_setopt_str(curl, CURLOPT_PROXYUSERPWD, config->proxyuserpwd); @@ -1460,6 +1463,10 @@ static CURLcode operate_do(struct GlobalConfig *global, * file (or terminal). If we write to a file, we must rewind * or close/re-open the file so that the next attempt starts * over from the beginning. + * + * TODO: similar action for the upload case. We might need + * to start over reading from a previous point if we have + * uploaded something when this was returned. */ break; } @@ -1534,6 +1541,8 @@ static CURLcode operate_do(struct GlobalConfig *global, download was not successful. */ long response; if(CURLE_OK == result) { + /* TODO We want to try next resource when download was + not successful. How to know that? */ char *effective_url = NULL; curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &effective_url); if(effective_url && @@ -1715,6 +1724,9 @@ static CURLcode operate_do(struct GlobalConfig *global, break; mlres = mlres->next; if(mlres == NULL) + /* TODO If metalink_next_res is 1 and mlres is NULL, + * set res to error code + */ break; } else |