diff options
| author | Jay Satiro <raysatiro@yahoo.com> | 2020-04-16 14:15:34 -0400 |
|---|---|---|
| committer | Jay Satiro <raysatiro@yahoo.com> | 2020-04-22 17:56:17 -0400 |
| commit | c0e139a60db68034e04362694290f7cf422eb924 (patch) | |
| tree | e7c0d414ccf98961d4dc0db1a2512529336c2d58 /tests/data/test1524 | |
| parent | bffa1165357a5964c44794c253019375c2a80250 (diff) | |
transfer: Switch PUT to GET/HEAD on 303 redirect
Prior to this change if there was a 303 reply to a PUT request then
the subsequent request to respond to that redirect would also be a PUT.
It was determined that was most likely incorrect based on the language
of the RFCs. Basically 303 means "see other" resource, which implies it
is most likely not the same resource, therefore we should not try to PUT
to that different resource.
Refer to the discussions in #5237 and #5248 for more information.
Fixes https://github.com/curl/curl/issues/5237
Closes https://github.com/curl/curl/pull/5248
Diffstat (limited to 'tests/data/test1524')
| -rw-r--r-- | tests/data/test1524 | 77 |
1 files changed, 77 insertions, 0 deletions
diff --git a/tests/data/test1524 b/tests/data/test1524 new file mode 100644 index 000000000..ed0c0476e --- /dev/null +++ b/tests/data/test1524 @@ -0,0 +1,77 @@ +<testcase> +<info> +<keywords> +HTTP +HTTP PUT +followlocation +</keywords> +</info> +# +# Server-side +<reply> +<data> +HTTP/1.1 303 OK swsclose +Location: moo.html&testcase=/15240002 +Connection: close + +</data> +<data2> +HTTP/1.1 200 OK swsclose +Location: this should be ignored +Connection: close + +body +</data2> +<datacheck> +HTTP/1.1 303 OK swsclose +Location: moo.html&testcase=/15240002 +Connection: close + +HTTP/1.1 200 OK swsclose +Location: this should be ignored +Connection: close + +body +</datacheck> +</reply> + +# +# Client-side +<client> +<server> +http +</server> + <name> +HTTP PUT with 303 redirect + </name> + <command> +http://%HOSTIP:%HTTPPORT/blah/1524 -L -T log/upload1524.txt +</command> +<file name="log/upload1524.txt"> +moo +</file> +</client> + +# +# Verify data after the test has been "shot" +<verify> +<strip> +^User-Agent:.* +</strip> +<protocol nonewline="yes"> +PUT /blah/1524 HTTP/1.1
+Host: %HOSTIP:%HTTPPORT
+Accept: */*
+Content-Length: 4
+Expect: 100-continue
+
+moo +GET /blah/moo.html&testcase=/15240002 HTTP/1.1
+User-Agent: this should be ignored
+Host: %HOSTIP:%HTTPPORT
+Accept: */*
+
+ +</protocol> +</verify> +</testcase> |