diff options
| author | Patrick Monnerat <patrick@monnerat.net> | 2020-03-07 11:51:00 +0100 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2020-03-07 23:26:00 +0100 |
| commit | 1e4cb333ef632bf081045bb7b36f0736bec52708 (patch) | |
| tree | 0ff5f7038008e8dc2f76dd679d135a12a7e1a9c4 /tests/libtest/lib654.c | |
| parent | 96972ec1c00a142e3859efc82a06b0b810527da2 (diff) | |
mime: do not perform more than one read in a row
Input buffer filling may delay the data sending if data reads are slow.
To overcome this problem, file and callback data reads do not accumulate
in buffer anymore. All other data (memory data and mime framing) are
considered as fast and still concatenated in buffer.
As this may highly impact performance in terms of data overhead, an early
end of part data check is added to spare a read call.
When encoding a part's data, an encoder may require more bytes than made
available by a single read. In this case, the above rule does not apply
and reads are performed until the encoder is able to deliver some data.
Tests 643, 644, 645, 650 and 654 have been adapted to the output data
changes, with test data size reduced to avoid the boredom of long lists of
1-byte chunks in verification data.
New test 667 checks mimepost using single-byte read callback with encoder.
New test 668 checks the end of part data early detection.
Fixes #4826
Reported-by: MrdUkk on github
Diffstat (limited to 'tests/libtest/lib654.c')
| -rw-r--r-- | tests/libtest/lib654.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/tests/libtest/lib654.c b/tests/libtest/lib654.c index 45051a9c7..f9c8b9118 100644 --- a/tests/libtest/lib654.c +++ b/tests/libtest/lib654.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2018, Daniel Stenberg, <daniel@haxx.se>, et al. + * Copyright (C) 1998 - 2020, Daniel Stenberg, <daniel@haxx.se>, et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -26,11 +26,9 @@ static char data[]= #ifdef CURL_DOES_CONVERSIONS /* ASCII representation with escape sequences for non-ASCII platforms */ - "\x74\x68\x69\x73\x20\x69\x73\x20\x77\x68\x61\x74\x20\x77\x65\x20\x70" - "\x6f\x73\x74\x20\x74\x6f\x20\x74\x68\x65\x20\x73\x69\x6c\x6c\x79\x20" - "\x77\x65\x62\x20\x73\x65\x72\x76\x65\x72\x0a"; + "\x64\x75\x6d\x6d\x79\x0a"; #else - "this is what we post to the silly web server\n"; + "dummy\n"; #endif struct WriteThis { |