Overhauled test suite getpart() function. Fixing potential out of bounds

stack and memory overwrites triggered with huge test case definitions.

1 files changed, 5 insertions, 1 deletions

diff --git a/tests/server/tftpd.c b/tests/server/tftpd.c
index 91e51cf42..152324904 100644
--- a/tests/server/tftpd.c
+++ b/tests/server/tftpd.c
@@ -1051,8 +1051,12 @@ static int validate_access(struct testcase *test,
       }
       else {
         size_t count;
-        test->buffer = (char *)spitout(stream, "reply", partbuf, &count);
+        error = getpart(&test->buffer, &count, "reply", partbuf, stream);
         fclose(stream);
+        if(error) {
+          logmsg("getpart() failed with error: %d", error);
+          return EACCESS;
+        }
         if(test->buffer) {
           test->rptr = test->buffer; /* set read pointer */
           test->bufsize = count;    /* set total count */