diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/tool_cfgable.c | 6 | ||||
| -rw-r--r-- | src/tool_formparse.c | 1 | ||||
| -rw-r--r-- | src/tool_operate.c | 12 | ||||
| -rw-r--r-- | src/tool_urlglob.c | 3 |
4 files changed, 4 insertions, 18 deletions
diff --git a/src/tool_cfgable.c b/src/tool_cfgable.c index fabd6d635..7d178e47c 100644 --- a/src/tool_cfgable.c +++ b/src/tool_cfgable.c @@ -34,11 +34,11 @@ void config_init(struct OperationConfig* config) config->use_httpget = FALSE; config->create_dirs = FALSE; config->maxredirs = DEFAULT_MAXREDIRS; - config->proto = CURLPROTO_ALL; /* FIXME: better to read from library */ + config->proto = CURLPROTO_ALL; config->proto_present = FALSE; config->proto_redir = CURLPROTO_ALL & /* All except FILE, SCP and SMB */ - ~(CURLPROTO_FILE | CURLPROTO_SCP | CURLPROTO_SMB | - CURLPROTO_SMBS); + ~(CURLPROTO_FILE | CURLPROTO_SCP | CURLPROTO_SMB | + CURLPROTO_SMBS); config->proto_redir_present = FALSE; config->proto_default = NULL; config->tcp_nodelay = TRUE; /* enabled by default */ diff --git a/src/tool_formparse.c b/src/tool_formparse.c index 49993470b..51aebd25a 100644 --- a/src/tool_formparse.c +++ b/src/tool_formparse.c @@ -568,7 +568,6 @@ static int get_param_part(struct OperationConfig *config, char endchar, endpos--; sep = *p; *endpos = '\0'; - /* TODO: maybe special fopen for VMS? */ fp = fopen(hdrfile, FOPEN_READTEXT); if(!fp) warnf(config->global, "Cannot read from %s: %s\n", hdrfile, diff --git a/src/tool_operate.c b/src/tool_operate.c index 6ed06e0f4..835303c53 100644 --- a/src/tool_operate.c +++ b/src/tool_operate.c @@ -101,7 +101,6 @@ CURLcode curl_easy_perform_ev(CURL *easy); static bool is_fatal_error(CURLcode code) { switch(code) { - /* TODO: Should CURLE_PEER_FAILED_VERIFICATION be a critical error? */ case CURLE_FAILED_INIT: case CURLE_OUT_OF_MEMORY: case CURLE_UNKNOWN_OPTION: @@ -876,8 +875,6 @@ static CURLcode operate_do(struct GlobalConfig *global, #if !defined(CURL_DISABLE_PROXY) { - /* TODO: Make this a run-time check instead of compile-time one. */ - my_setopt_str(curl, CURLOPT_PROXY, config->proxy); /* new in libcurl 7.5 */ if(config->proxy) @@ -1663,10 +1660,6 @@ static CURLcode operate_do(struct GlobalConfig *global, * file (or terminal). If we write to a file, we must rewind * or close/re-open the file so that the next attempt starts * over from the beginning. - * - * TODO: similar action for the upload case. We might need - * to start over reading from a previous point if we have - * uploaded something when this was returned. */ break; } @@ -1757,8 +1750,6 @@ static CURLcode operate_do(struct GlobalConfig *global, download was not successful. */ long response; if(CURLE_OK == result) { - /* TODO We want to try next resource when download was - not successful. How to know that? */ char *effective_url = NULL; curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &effective_url); if(effective_url && @@ -1932,9 +1923,6 @@ static CURLcode operate_do(struct GlobalConfig *global, break; mlres = mlres->next; if(mlres == NULL) - /* TODO If metalink_next_res is 1 and mlres is NULL, - * set res to error code - */ break; } else if(urlnum > 1) { diff --git a/src/tool_urlglob.c b/src/tool_urlglob.c index e9007b2b4..d6f7104ac 100644 --- a/src/tool_urlglob.c +++ b/src/tool_urlglob.c @@ -553,8 +553,7 @@ CURLcode glob_next_url(char **globbed, URLGlob *glob) } } if(carry) { /* first pattern ptr has run into overflow, done! */ - /* TODO: verify if this should actually return CURLE_OK. */ - return CURLE_OK; /* CURLE_OK to match previous behavior */ + return CURLE_OK; } } |