aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-13winbuild: Support MultiSSL buildsJan-E
- Remove the lines in winbuild/Makefile.vc that generate an error with multiple SSL backends. - Add /DCURL_WITH_MULTI_SSL in winbuild/MakefileBuild.vc if multiple SSL backends are set. Closes https://github.com/curl/curl/pull/3772
2019-04-12travis: remove mesalink builds (temporarily?)Daniel Stenberg
Since the mesalink build started to fail on travis, even though we build a fixed release version, we disable it to prevent it from blocking progress. Closes #3767
2019-04-12openssl: mark connection for close on TLS close_notifyDaniel Stenberg
Without this, detecting and avoid reusing a closed TLS connection (without a previous GOAWAY) when doing HTTP/2 is tricky. Reported-by: Tom van der Woerdt Fixes #3750 Closes #3763
2019-04-12RELEASE-NOTES: syncedDaniel Stenberg
2019-04-11vauth/cleartext: Update the PLAIN login function signature to match RFC 4616Steve Holme
Functionally this doesn't change anything as we still use the username for both the authorisation identity and the authentication identity. Closes #3757
2019-04-11test1906: verify CURLOPT_CURLU + CURLOPT_PORT usageDaniel Stenberg
Based-on-code-by: Poul T Lomholt
2019-04-11url: always clone the CUROPT_CURLU handleDaniel Stenberg
Since a few code paths actually update that data. Fixes #3753 Closes #3761 Reported-by: Poul T Lomholt
2019-04-11CURLOPT_DNS_USE_GLOBAL_CACHE: removeDaniel Stenberg
Remove the code too. The functionality has been disabled in code since 7.62.0. Setting this option will from now on simply be ignored and have no function. Closes #3654
2019-04-11travis: install libgnutls28-dev only for --with-gnutls buildMarcel Raad
Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
2019-04-11travis: install libnss3-dev only for --with-nss buildMarcel Raad
Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
2019-04-11travis: install libssh2-dev only for --with-libssh2 buildMarcel Raad
Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
2019-04-11travis: install libssh-dev only for --with-libssh buildMarcel Raad
Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
2019-04-11travis: install krb5-user only for --with-gssapi buildMarcel Raad
Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
2019-04-11travis: install lcov only for the coverage jobMarcel Raad
Reduces the time needed for the other jobs a little. Closes https://github.com/curl/curl/pull/3721
2019-04-11travis: install clang only when neededMarcel Raad
This reduces the GCC job runtimes a little and it's needed to selectively update clang builds to xenial. Closes https://github.com/curl/curl/pull/3721
2019-04-11AppVeyor: enable testing for WinSSL buildMarcel Raad
Closes https://github.com/curl/curl/pull/3725
2019-04-11build: fix Codacy/CppCheck warningsMarcel Raad
- remove unused variables - declare conditionally used variables conditionally - suppress unused variable warnings in the CMake tests - remove dead variable stores - consistently use WIN32 macro to detect Windows Closes https://github.com/curl/curl/pull/3739
2019-04-11polarssl_threadlock: remove conditionally unused codeMarcel Raad
Make functions no-ops if neither both USE_THREADS_POSIX and HAVE_PTHREAD_H nor both USE_THREADS_WIN32 and HAVE_PROCESS_H are defined. Previously, if only one of them was defined, there was either code compiled that did nothing useful or the wrong header included for the functions used. Also, move POLARSSL_MUTEX_T define to implementation file as it's not used externally. Closes https://github.com/curl/curl/pull/3739
2019-04-11lib557: initialize variablesMarcel Raad
These variables are only conditionally initialized. Closes https://github.com/curl/curl/pull/3739
2019-04-11lib509: add missing include for strdupMarcel Raad
Closes https://github.com/curl/curl/pull/3739
2019-04-11README.md: fix no-consecutive-blank-lines Codacy warningMarcel Raad
Consistently use one blank line between blocks. Closes https://github.com/curl/curl/pull/3739
2019-04-11tests/server/util: fix Windows Unicode buildMarcel Raad
Always use the ANSI version of FormatMessage as we don't have the curl_multibyte gear available here. Closes https://github.com/curl/curl/pull/3758
2019-04-11curl_easy_getinfo.3: fix minor formatting mistakeDaniel Stenberg
2019-04-11xattr: skip unittest on unsupported platformsDaniel Gustafsson
The stripcredentials unittest fails to compile on platforms without xattr support, for example the Solaris member in the buildfarm which fails with the following: CC unit1621-unit1621.o CC ../libtest/unit1621-first.o CCLD unit1621 Undefined first referenced symbol in file stripcredentials unit1621-unit1621.o goto problem 2 ld: fatal: symbol referencing errors. No output written to .libs/unit1621 collect2: error: ld returned 1 exit status gmake[2]: *** [Makefile:996: unit1621] Error 1 Fix by excluding the test on such platforms by using the reverse logic from where stripcredentials() is defined. Closes #3759 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
2019-04-11emailL Added reference to RFC8314 for implicit TLSSteve Holme
2019-04-10README: Schannel, stop calling it "winssl"Steve Holme
Stick to "Schannel" everywhere - follow up to 180501cb.
2019-04-10cmake: clear CMAKE_REQUIRED_LIBRARIES after each useJakub Zakrzewski
This fixes GSSAPI builds with the libraries in a non-standard location. The testing for recv() were failing because it failed to link the Kerberos libraries, which are not needed for this or subsequent tests. fixes #3743 closes #3744
2019-04-10cmake: avoid linking executable for some tests with cmake 3.6+Jakub Zakrzewski
With CMAKE_TRY_COMPILE_TARGET_TYPE set to STATIC_LIBRARY, the try_compile() (which is used by check_c_source_compiles()) will build static library instead of executable. This avoids linking additional libraries in and thus speeds up those checks a little. This commit also avoids #3743 (GSSAPI build errors) on itself with cmake 3.6 or above. That issue was fixed separately for all versions. Ref: #3744
2019-04-10cmake: minor cleanupJakub Zakrzewski
- Remove nneeded include_regular_expression. It was setting what is already a default. - Remove duplicated include. - Don't check for pre-3.0.0 CMake version. We already require at least 3.0.0, so it's just clutter. Ref: #3744
2019-04-08build-openssl.bat: Fixed support for OpenSSL v1.1.0+Steve Holme
2019-04-08build-openssl.bat: Perfer the use of if statements rather than goto (where ↵Steve Holme
possible)
2019-04-08build-openssl.bat: Perform the install for each build type directly after ↵Steve Holme
the build
2019-04-08build-openssl.bat: Split the install of static and shared build typesSteve Holme
2019-04-08build-openssl.bat: Split the building of static and shared build typesSteve Holme
2019-04-08build-openssl.bat: Move the installation into a separate functionSteve Holme
2019-04-08build-openssl.bat: Move the build step into a separate functionSteve Holme
2019-04-08build-openssl.bat: Move the OpenSSL configuration into a separate functionSteve Holme
2019-04-08build-openssl.bat: Fixed the BUILD_CONFIG variable not being initialisedSteve Holme
Should the parent environment set this variable then the build might not be performed as the user intended.
2019-04-08socks: fix error messageDaniel Stenberg
2019-04-08config.d: clarify that initial : and = might need quoting [skip ci]Daniel Stenberg
Fixes #3738 Closes #3749
2019-04-08RELEASE-NOTES: syncedDaniel Stenberg
bumped to 7.65.0 for next release
2019-04-07socks5: user name and passwords must be shorter than 256Daniel Stenberg
bytes... since the protocol needs to store the length in a single byte field. Reported-by: XmiliaH on github Fixes #3737 Closes #3740
2019-04-07test: urlapi: urlencode characters above 0x7f correctlyJakub Zakrzewski
2019-04-07urlapi: urlencode characters above 0x7f correctlyJakub Zakrzewski
fixes #3741 Closes #3742
2019-04-07multi_runsingle(): fix use-after-freeEven Rouault
Fixes #3745 Closes #3746 The following snippet ``` int main() { CURL* hCurlHandle = curl_easy_init(); curl_easy_setopt(hCurlHandle, CURLOPT_URL, "http://example.com"); curl_easy_setopt(hCurlHandle, CURLOPT_PROXY, "1"); curl_easy_perform(hCurlHandle); curl_easy_cleanup(hCurlHandle); return 0; } ``` triggers the following Valgrind warning ``` ==4125== Invalid read of size 8 ==4125== at 0x4E7D1EE: Curl_llist_remove (llist.c:97) ==4125== by 0x4E7EF5C: detach_connnection (multi.c:798) ==4125== by 0x4E80545: multi_runsingle (multi.c:1451) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ==4125== Address 0x9b3d1d0 is 1,120 bytes inside a block of size 1,600 free'd ==4125== at 0x4C2ECF0: free (vg_replace_malloc.c:530) ==4125== by 0x4E62C36: conn_free (url.c:756) ==4125== by 0x4E62D34: Curl_disconnect (url.c:818) ==4125== by 0x4E48DF9: Curl_once_resolved (hostip.c:1097) ==4125== by 0x4E8052D: multi_runsingle (multi.c:1446) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ==4125== Block was alloc'd at ==4125== at 0x4C2F988: calloc (vg_replace_malloc.c:711) ==4125== by 0x4E6438E: allocate_conn (url.c:1654) ==4125== by 0x4E685B4: create_conn (url.c:3496) ==4125== by 0x4E6968F: Curl_connect (url.c:4023) ==4125== by 0x4E802E7: multi_runsingle (multi.c:1368) ==4125== by 0x4E8197C: curl_multi_perform (multi.c:2072) ==4125== by 0x4E766A0: easy_transfer (easy.c:625) ==4125== by 0x4E76915: easy_perform (easy.c:719) ==4125== by 0x4E7697C: curl_easy_perform (easy.c:738) ==4125== by 0x4008BE: main (in /home/even/curl/test) ``` This has been bisected to commit 2f44e94 Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14109 Credit to OSS Fuzz
2019-04-06pipelining: removedDaniel Stenberg
As previously planned and documented in DEPRECATE.md, all pipelining code is removed. Closes #3651
2019-04-06tests: make Impacket (SMB server) Python 3 compatiblecclauss
Closes #3731 Fixes #3289
2019-04-06cmake: set SSL_BACKENDSSimon Warta
This groups all SSL backends into the feature "SSL" and sets the SSL_BACKENDS analogue to configure.ac Closes https://github.com/curl/curl/pull/3736
2019-04-06cmake: don't run SORT on empty listSimon Warta
In case of an empty list, SORTing leads to the cmake error "list sub-command SORT requires list to be present." Closes https://github.com/curl/curl/pull/3736
2019-04-05configure: fix default location for fish completionsEli Schwartz
Fish defines a vendor completions directory for completions that are not installed as part of the fish project itself, and the vendor completions are preferred if they exist. This prevents trying to overwrite the builtin curl.fish completion (or creating file conflicts in distro packaging). Prefer the pkg-config defined location exported by fish, if it can be found, and fall back to the correct directory defined by most systems. Closes #3723 Reviewed-by: Daniel Gustafsson