aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-01-27smtp.c: Fixed unnecessary state change if starttls failsSteve Holme
The state machine should only be changed to SMTP_STARTTLS when the STARTTLS command has been successfully sent to the server.
2013-01-27pop3.c: Fixed unnecessary state change if starttls failsSteve Holme
The state machine should only be changed to POP3_STARTTLS when the STLS command has been successfully sent to the server.
2013-01-27imap.c: Fixed unnecessary state change if starttls failsSteve Holme
The state machine should only be changed to IMAP_STARTTLS when the STARTTLS command has been successfully sent to the server.
2013-01-26email: Updated comment regarding ssldone usageSteve Holme
Updated the ssldone comment as multi mode is always used internally now.
2013-01-26zz40-xc-ovr.m4: emit witness message in configure BODYYang Tse
This avoids witness message in output when running configure --help, while sending the message to config.log for other configure runs.
2013-01-25smtp.c: Added comments to smtp_endofresp()Steve Holme
Minor code tidy up to add comments similar to those used in the pop3 and imap end of resp functions, in order to assist anyone reading the code and highlight the similarities between each of these protocols.
2013-01-25zz40-xc-ovr.m4: truly do version conditional overridingYang Tse
- version conditional overriding - catch unexpanded XC macros - fix double words in comments
2013-01-25zz40-xc-ovr.m4: fix variable assignment of subshell output bashismYang Tse
Tor Arntsen analyzed and reported the issue. URL: http://curl.haxx.se/mail/lib-2013-01/0306.html
2013-01-25zz40-xc-ovr.m4: reinstate strict AC_REQUIRE macro dependenciesYang Tse
2013-01-25zz40-xc-ovr.m4: avoid double single-quote usageYang Tse
2013-01-25zz40-xc-ovr.m4: parentheses balancing of 'case' statementsYang Tse
m4 quadrigraph shell comment technique allows proper autoconf parentheses balancing in shell 'case' statements. The presence of unbalanced parentheses may otherwise trigger expansion bugs.
2013-01-24smtp.c: Corrected RFC referencesSteve Holme
The most recent version of the SMTP RFC is RFC5321 and not RFC2821 as previously documented. Added RFC1870 and re-ordered list numerically.
2013-01-24smtp.c: Fixed failure detection during TLS upgradeSteve Holme
smtp_state_upgrade_tls() would attempt to incorrectly complete the upgrade to smtps and start the EHLO command if Curl_ssl_connect_nonblocking() returned a failure code and if ssldone was set to TRUE. This would only happen when a non-blocking API hadn't been provided by the SSL implementation and curlssl_connect() was called underneath.
2013-01-24pop3.c: Fixed failure detection during TLS upgradeSteve Holme
pop3_state_upgrade_tls() would attempt to incorrectly complete the upgrade to pop3s and start the CAPA command if Curl_ssl_connect_nonblocking() returned a failure code and if ssldone was set to TRUE. This would only happen when a non-blocking API hadn't been provided by the SSL implementation and curlssl_connect() was called underneath.
2013-01-24imap.c: Fixed failure detection during TLS upgradeSteve Holme
imap_state_upgrade_tls() would attempt to incorrectly complete the upgrade to imaps and start the CAPABILITY command if Curl_ssl_connect_nonblocking() returned a failure code and if ssldone was set to TRUE. This would only happen when a non-blocking API hadn't been provided by the SSL implementation and curlssl_connect() was called underneath.
2013-01-24zz40-xc-ovr.m4: internals overhaulingYang Tse
- Update comments - Execute commands in subshells - Faster path separator check - Fix missing 'test' command - Rename private macros - Minimize AC_REQUIRE usage
2013-01-23email: Removed unnecessary return statementsSteve Holme
Small tidy up to remove unnecessary return statements prior to the next fix.
2013-01-23zz40-xc-ovr.m4: redirect errors and warnings to stderrYang Tse
2013-01-23zz40-xc-ovr.m4: AC_REQUIRE also XC_CONFIGURE_PREAMBLE success messageYang Tse
2013-01-23zz60-xc-ovr.m4: tighten XC_OVR_ZZ60 macro placement requirementsYang Tse
2013-01-23configure: use XC_CONFIGURE_PREAMBLE early checksYang Tse
Some basic checks we make were placed early enough in generated configure script when using autoconf 2.5X versions. Newer autoconf versions expand these checks much further into the configure script, rendering them useless. Using XC_CONFIGURE_PREAMBLE fixes placement of early intended checks across all our autoconf supported versions.
2013-01-23zz40-xc-ovr.m4: provide XC_CONFIGURE_PREAMBLE macroYang Tse
2013-01-23FAQ: update the SSL lib list and wording in question 2.2Daniel Stenberg
2013-01-22curl_sasl.c: Corrected references to RFCSteve Holme
The most recent version of the RFC is RFC4422 and not RFC2222 as previously documented.
2013-01-22email: Corrected references to SASL RFCSteve Holme
The most recent version of the SASL RFC is RFC4422 and not RFC2222 as previously documented.
2013-01-22formpost: support quotes, commas and semicolon in file namesUlion
- document the double-quote and backslash need be escaped if quoting. - libcurl formdata escape double-quote in filename by backslash. - curl formparse can parse filename both contains '"' and ',' or ';'. - curl now can uploading file with ',' or ';' in filename. Bug: http://curl.haxx.se/bug/view.cgi?id=1171
2013-01-22memanalyze.pl: handle fopen() of file names with quotesDaniel Stenberg
2013-01-21xc-cc-check.m4: re-evaluate exporting and AC_SUBST'ing varsYang Tse
Notes: When running a configure script that has nested packages (for example libcurl's configure with --enable-ares and c-ares sources embedded in curl tree) and AC_CONFIG_SUBDIRS([nested-subdir]) machinery is used to automatically run the nested configure script from within the parent configure script, it happens that the nested _shell_ script will inherit shell variables exported from the parent _shell_ script. If for example parent configure script sets and exports LDFLAGS and LIBS variables with proper values in order to link either a parent library or program with a library which will be configured and built by a nested package; It will happen that when the nested configure script runs, the nested library does not exist yet and _any_ link-test done in the nested configure will fail, such as those that autoconf macros perform in order to detect existing compiler and its characteristics, the result is that the nested configure script will fail with errors such as: configure: error: C compiler cannot create executables For now, we no longer export variables previously exported here. On the other hand, AC_SUBST'ing them is appropriate and even with nested packages each package's config.status gets its own package values. So we reinstate AC_SUBST'ing previously AC_SUBST'ed variables.
2013-01-21FAQ: 3.22 curl -X gives me HTTP problemsDaniel Stenberg
2013-01-21xc-cc-check.m4: avoid recursive package automake'ing breakageYang Tse
2013-01-20xc-cc-check.m4: mark earlier variables that are to be exportedYang Tse
2013-01-20configure: autotools compatibility fixes - step IYang Tse
Fix proper macro expansion order across autotools versions for C compiler and preprocessor program checks.
2013-01-20pop3.c: Fixed conditional compilation of the apop response functionSteve Holme
Extended the fix from commit 8b15c84ea91e to additionally exclude pop3_state_apop_resp() if the CURL_DISABLE_CRYPTO_AUTH flag is defined.
2013-01-20Makefile.inc: fix $(top_srcdir) not allowed in _SOURCES variablesYang Tse
2013-01-19formadd: reject trying to read a directory where a file is expectedDaniel Stenberg
Bug: http://curl.haxx.se/mail/archive-2013-01/0017.html Reported by: Ulrich Doehner
2013-01-19curl_easy_send.3: document return codesDaniel Stenberg
Reported by: Craig Davison Bug: http://curl.haxx.se/mail/lib-2013-01/0234.html
2013-01-19curl_easy_recv.3: document return codesDaniel Stenberg
Reported by: Craig Davison Bug: http://curl.haxx.se/mail/lib-2013-01/0234.html
2013-01-19email: General code tidy upSteve Holme
Corrected some function argument definitions to maximize the 80 character line length limit and be in keeping with the curl coding style.
2013-01-18pop3.c: Fixed a problem with pop3s connections not connecting properlySteve Holme
Fixed an issue where Curl_ssl_connect_nonblocking() wouldn't complete correctly and the ssldone flag wouldn't be set to true for pop3s based connections. Bug introduced in commit: 4ffb8a6398ed.
2013-01-18RELEASE-NOTES: add references to several bugfixes+changesDaniel Stenberg
2013-01-18RELEASE-NOTES: Added missing imap fixSteve Holme
Added missing imap fix as per commit 709b3506cd9b.
2013-01-18runtests.pl: make VPATH builds find valgrind.suppYang Tse
2013-01-18RELEASE-NOTES: synced with c43127414d89Daniel Stenberg
2013-01-17always-multi: always use non-blocking internalsDaniel Stenberg
Remove internal separated behavior of the easy vs multi intercace. curl_easy_perform() is now using the multi interface itself. Several minor multi interface quirks and bugs have been fixed in the process. Much help with debugging this has been provided by: Yang Tse
2013-01-17url.c: fix HTTP CONNECT tunnel establishment upon delayed responseYang Tse
Fixes initial proxy response being processed by the tunneled protocol handler instead of the HTTP wrapper handler. This issue would trigger upon delayed CONNECT response from the proxy. Additionally fixes a multi interface code-path in which connections would not time out properly. This does not fix known bug #39. URL: http://curl.haxx.se/mail/lib-2013-01/0191.html
2013-01-16--libcurl: fix for non-zero default optionsYves Arrouye
If the default value for an option taking a long as its value is non zero, and it is set by zero by a command line option, then that command line option is not reflected in --libcurl's output. This is because line 520-521 of tool_setopt.c look like: if(!lval) skip = TRUE; An example of a command-line option doing so is the -k option that sets CURLOPT_SLL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST to 0L, when the defaults are non-zero.
2013-01-15FTP: reject illegal port numbers in EPSV 229 responsesDaniel Stenberg
2013-01-15commit bc682cbd follow-upYang Tse
2013-01-15build: use per-target '_CPPFLAGS' for those currently using defaultYang Tse
Automake documents that doing this will make it choose a different name for intermediate object files even when sharing source files across targets of same Makefile.am. Up to automake 1.13.1 target's intermediate object files were placed in the build subdirectory of the target. We depended on this, probably undocumented behavior, to achieve same behavior as if a per-target flag had been specified when building targets that actually belong to different Makefile.am files. It seems automake 1.13.2 is going to break behavior mentioned above. So, lets use a documented behavior in order to achieve same purpose, across automake versions, no matter where automake wishes to place intermediate object files. Our build targets that already were using a per-target '_CFLAGS' or '_CPPFLAGS' need no 'fixing', these were already 'fixed'. The only Makefile.am or Makefile.in files in libcurl's source tree touched by this 'fix' are tests/libtest/Makefile.inc and tests/unit/Makefile.inc.
2013-01-15tests/libtest/Makefile.inc: sort build targetsYang Tse