aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-08-08curl_version: fixed Value stored to 'len' is never readDaniel Stenberg
Fixed this (harmless) clang-analyzer warning. Also fixed the source indentation level.
2012-08-08TODO-RELEASE: the (nil) bug is fixedDaniel Stenberg
2012-08-08add_next_timeout: minor restructure of codeDaniel Stenberg
By reading the ->head pointer and using that instead of the ->size number to figure out if there's a list remaining we avoid the (false positive) clang-analyzer warning that we might dereference of a null pointer.
2012-08-08verbose messages: fixed output of hostnames in re-used connectionsDaniel Stenberg
I suspect this is a regression introduced in commit 207cf150, included since 7.24.0. Avoid showing '(nil)' as hostname in verbose output by making sure the hostname fixup function is called early enough to set the pointers that are used for this. The name data is set again for each request even for re-used connections to handle multiple hostnames over the same connection (like with proxy) or that the casing etc of the host name is changed between requests (which has proven to be important at least once in the past). Test1011 was modified to use a redirect with a re-used a connection since it then showed the bug and now lo longer does. There's currently no easy way to have the test suite detect 'nil' texts in verbose ouputs so no tests will detect if this problem gets reintroduced. Bug: http://curl.haxx.se/mail/lib-2012-07/0111.html Reported by: Gisle Vanem
2012-08-08metalink: Un-broke the build when building --with-darwinsslNick Zitzmann
2012-08-08Fix some compiler warnings.Guenter Knauf
2012-08-08TODO-RELEASE: two bugs fixedDaniel Stenberg
These are now addressed: 323 - patch - select.c / Curl_socket_check() interrupted 325 - Avoid leak of local device string when reusing connection
2012-08-08curl.1: minor format fix for --data-asciiDaniel Stenberg
... and removal of trailing whitespace on a single line
2012-08-07curl man page cleanupAnt Bryan
2012-08-07Avoid leak of local device string when reusing connectionMike Crowe
Ensure that the copy of the CURLOPT_INTERFACE string is freed if we decide we can reuse an existing connection.
2012-08-07Curl_socket_check: fix timeout return value for select usersDaniel Stenberg
This is the same fix applied for the conditional code that uses select() that was already done for the poll specific code in commit b61e8b81f5038.
2012-08-07Curl_socket_check: fix return code for timeoutMaxime Larocque
We found a problem with ftp transfer using libcurl (7.23 and 7.25) inside an application which is receiving unix signals (SIGUSR1, SIGUSR2...) almost continuously. (Linux 2.4, PowerPC, HAVE_POLL_FINE defined). Curl_socket_check() uses poll() to wait for the socket, and retries it when a signal is received (EINTR). However, if a signal is received and it also happens that the timeout has been reached, Curl_socket_check() returns -1 instead of 0 (indicating an error instead of a timeout). In our case, the result is an aborted connection even before the ftp banner is received from the server, and a return value of CURLE_OUT_OF_MEMORY from curl_easy_perform() (Curl_pp_multi_statemach(), in pingpong.c, actually returns OOM if Curl_socket_check() fails :-) Funny to debug on a system on which OOM is a possible cause). Bug: http://curl.haxx.se/mail/lib-2012-07/0122.html
2012-08-07RELEASE-NOTES: synced with b4a558041fdf65c0Daniel Stenberg
2012-08-07TODO-RELEASE: fixed another bugDaniel Stenberg
bug #3544688 "crash during retry with libcurl and SFTP"
2012-08-07WSAPoll: disabled on all windows buildsDaniel Stenberg
Due to WSAPoll bugs, libcurl does not work as intended. When the cURL library is used to setup a connection to an incorrect port, normally the result is CURLE_COULDNT_CONNECT, /* 7 */, but due to the bug in WSAPoll, the result now is CURLE_OPERATION_TIMEDOUT, /* 28 - the timeout time was reached */. On August 1, Jan Koen Annot opened a case for this to Microsoft Premier Online (https://premier.microsoft.com/). The support engineer handling the case wrote that the case description is quite clear. He will try to reproduce the issue and then proceed with troubleshooting it. Reported by: Jan Koen Annot Bug: http://curl.haxx.se/mail/lib-2012-07/0310.html
2012-08-07retry request: only access the HTTP data if in fact HTTPDaniel Stenberg
When figuring out if the data stream needs to be rewound when the request is to be resent, we must not access the HTTP struct unless the protocol used is indeed HTTP... Bug: http://curl.haxx.se/bug/view.cgi?id=3544688
2012-08-07TODO: support DANE, we already support gnutls without gcryptDaniel Stenberg
2012-08-07curl-config: parentheses fixDaniel Stenberg
Braces, not parentheses, should be used for shell variable names. Bug: http://curl.haxx.se/bug/view.cgi?id=3551460 Reported by: Edward Sheldrake
2012-08-07VC build: add define for opensslDaniel Stenberg
This fixes a build failure of lib/ssluse.c. Bug: http://curl.haxx.se/bug/view.cgi?id=3552997
2012-08-07TODO-RELEASE: two bugs fixed!Daniel Stenberg
2012-08-07globbing: fix segfault when >9 globs were usedDaniel Stenberg
Stupid lack of range checks caused the code to overwrite local variables after glob number nine. Added checks now. Bug: http://curl.haxx.se/bug/view.cgi?id=3546353
2012-08-07sws: close sockets properlyJoe Mason
Fix a bug where closed sockets (fd -1) were left in the all_sockets list, because of missing parens in a pointer arithmetic expression Reenable the tests that were locking up due to this bug.
2012-08-07Remove debug logs that were accidentally checked inJoe Mason
2012-08-07Use select in sws, which has better cross-platform support than pollJoe Mason
2012-08-07Use cross-platform curlx_nonblock instead of fcntl in swsJoe Mason
2012-08-06operate: fix clang-analyzer warnings for never read variablesDaniel Stenberg
Two separate "Value stored to 'XXX' is never read" warnings
2012-08-06operate: fix clang-analyzer warningDaniel Stenberg
Value stored to 'separator' is never read
2012-08-06metalink: change code order to build with gnutls-nettleDaniel Stenberg
Bug: http://curl.haxx.se/bug/view.cgi?id=3554668 Reported by: Anthony G. Basile
2012-08-06gtls: fix build failure by including nettle-specific headersDaniel Stenberg
Bug: http://curl.haxx.se/bug/view.cgi?id=3554668 Reported by: Anthony G. Basile
2012-08-06Fixed compiler warning - argument is type long.Guenter Knauf
2012-08-06DISABLED: disable the new tests that do NTLMDaniel Stenberg
The tests 2025, 2028 and 2031 don't work for me so I'll have them disabled for now until we solve the problem.
2012-08-03Add tests of auth retriesJoe Mason
2012-08-03Cleanup handshake after clean NTLM failureJoe Mason
2012-08-03Zero out auth structs before transferJoe Mason
2012-08-02Add a polling loop in main to read from more than one socket at once. Add ↵Joe Mason
the O_NONBLOCK and SO_KEEPALIVE flag to all sockets. Note that several loops which used to continue on a return value of 0 (theoretical since 0 would never be returned without O_NONBLOCK) now break on 0 so that they won't continue reading until after poll is called again.
2012-08-02Change return values of get_request, accept_connection and ↵Joe Mason
service_connection to add a return code for non-blocking sockets: now -1 means error or connection finished, 1 means data was read, and 0 means there is no data available now so need to wait for poll (new return value)
2012-08-02Hoist the loop out of get_request, and make sure that it can be reentered ↵Joe Mason
when a request is half-finished. Note the the req struct used to be re-initialized AFTER reading pipeline data, so now that we initialize it from the caller we must be careful not to overwrite the pipeline data. Also we now need to handle the case where the buffer is already full when get_request is called - previously this never happened as it was always called with an empty buffer and looped until done. Now get_request is called in a loop, so the next step is to run the loop on a socket only when poll signals it is readable.
2012-08-02Move blocks of code from the sws main loop into their own functions for ↵Joe Mason
easier refactoring later. The next step will be to call the correct function after a poll, rather than looping unconditionally
2012-08-02Remove the --fork option of sws, since it makes refactoring to use poll more ↵Joe Mason
complicated and should be redundant once we poll
2012-07-30file: use fdopen() for uploaded files if availableKamil Dudka
It eliminates noisy events when using inotify and fixes a TOCTOU issue. Bug: https://bugzilla.redhat.com/844385
2012-07-29Added DWANT_IDN_PROTOTYPES define for MSVC too.Guenter Knauf
Discussion on the list: http://curl.haxx.se/mail/lib-2012-07/0271.html
2012-07-29Added Win32 problems.Guenter Knauf
2012-07-29Added hint to read docs/INSTALL too.Guenter Knauf
2012-07-29Added new file to distro.Guenter Knauf
2012-07-28TODO: Updated after 7.27.0 releaseSteve Holme
Removed APOP and SASL authentication from the POP3 section and metalink support from the client section as these features were implemented in this release. Moved adding gssapi to SASL into it's own section rather than repeat it for each protocol.
2012-07-28TODO-RELEASE: updated after 7.27.0 releaseDaniel Stenberg
2012-07-28THANKS: 12 new contributors from the 7.27.0 releaseDaniel Stenberg
2012-07-27version bump: start towards next releaseDaniel Stenberg
Let's call it 7.27.1 for now, but it it probably going to become 7.28.0 when released.
2012-07-27Fixed compiler warning 'unused parameter'.Guenter Knauf
2012-07-27Added prototypes to kill compiler warning.Guenter Knauf