aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-28http: do not treat FTPS over CONNECT as HTTPSKamil Dudka
If we use FTPS over CONNECT, the TLS handshake for the FTPS control connection needs to be initiated in the SENDPROTOCONNECT state, not the WAITPROXYCONNECT state. Otherwise, if the TLS handshake completed without blocking, the information about the completed TLS handshake would be saved to a wrong flag. Consequently, the TLS handshake would be initiated in the SENDPROTOCONNECT state once again on the same connection, resulting in a failure of the TLS handshake. I was able to observe the failure with the NSS backend if curl ran through valgrind. Note that this commit partially reverts curl-7_21_6-52-ge34131d.
2017-03-28pause: handle mixed types of data when pausedDaniel Stenberg
When receiving chunked encoded data with trailers, and the write callback returns PAUSE, there might be both body and header to store to resend on unpause. Previously libcurl returned error for that case. Added test case 1540 to verify. Reported-by: Stephen Toub Fixes #1354 Closes #1357
2017-03-28http: Fix proxy connection reuse with basic-authIsaac Boukris
When using basic-auth, connections and proxy connections can be re-used with different Authorization headers since it does not authenticate the connection (like NTLM does). For instance, the below command should re-use the proxy connection, but it currently doesn't: curl -v -U alice:a -x http://localhost:8181 http://localhost/ --next -U bob:b -x http://localhost:8181 http://localhost/ This is a regression since refactoring of ConnectionExists() as part of: cb4e2be7c6d42ca0780f8e0a747cecf9ba45f151 Fix the above by removing the username and password compare when re-using proxy connection at proxy_info_matches(). However, this fix brings back another bug would make curl to re-print the old proxy-authorization header of previous proxy basic-auth connection because it wasn't cleared. For instance, in the below command the second request should fail if the proxy requires authentication, but would succeed after the above fix (and before aforementioned commit): curl -v -U alice:a -x http://localhost:8181 http://localhost/ --next -x http://localhost:8181 http://localhost/ Fix this by clearing conn->allocptr.proxyuserpwd after use unconditionally, same as we do for conn->allocptr.userpwd. Also fix test 540 to not expect digest auth header to be resent when connection is reused. Signed-off-by: Isaac Boukris <iboukris@gmail.com> Closes https://github.com/curl/curl/pull/1350
2017-03-28openssl: exclude DSA code when OPENSSL_NO_DSA is definedJay Satiro
- Fix compile errors that occur in openssl.c when OpenSSL lib was built without DSA support. Bug: https://github.com/curl/curl/issues/1361 Reported-by: neheb@users.noreply.github.com
2017-03-28examples/fopen: checksrc complianceJay Satiro
2017-03-28schannel: fix variable shadowing warningMarcel Raad
No need to redeclare the variable.
2017-03-27multi: fix MinGW-w64 compiler warningsMarcel Raad
error: conversion to 'long int' from 'time_t {aka long long int}' may alter its value [-Werror=conversion]
2017-03-27.gitattributes: turn off CRLF for *.amMarcel Raad
If Makefile.am uses CRLF, buildconf in a Windows checkout fails with: ".ibtoolize: error: AC_CONFIG_MACRO_DIRS([m4]) conflicts with ACLOCAL_AMFLAGS=-I m4"
2017-03-26spelling fixesklemens
Closes #1356
2017-03-25curl: check for end of input in writeout backslash handlingDaniel Stenberg
Reported-by: Brian Carpenter Added test 1442 to verify
2017-03-24tests/README: make "Run" section foolproofMarcel Raad
curl must be built before building the tests. Closes https://github.com/curl/curl/pull/1352
2017-03-23openssl: fix comparison between signed and unsigned integer expressionsDaniel Stenberg
2017-03-23asiohiper: make sure socket is open in event_cbEdward Kimmel
Send curl_socket_t to event_cb and make sure it hasn't been closed yet. Closes https://github.com/curl/curl/pull/1318
2017-03-23openssl: made the error table static constDan Fandrich
2017-03-23openssl: fall back on SSL_ERROR_* string when no error detailJay Satiro
- If SSL_get_error is called but no extended error detail is available then show that SSL_ERROR_* as a string. Prior to this change there was some inconsistency in that case: the SSL_ERROR_* code may or may not have been shown, or may have been shown as unknown even if it was known. Ref: https://github.com/curl/curl/issues/1300 Closes https://github.com/curl/curl/pull/1348
2017-03-23mkhelp: disable compression if the perl gzip module is unavailableDan Fandrich
This is nowadays included with the base perl distribution, but wasn't prior to about perl 5.14
2017-03-23tests/README: mention nroff for --manual testsAnders Roxell
Signed-off-by: Anders Roxell <anders.roxell@gmail.com> Closes #1342
2017-03-22CURLINFO_PRIMARY_IP.3: add exampleDaniel Stenberg
2017-03-22travis: run tests-nonflaky instead of tests-fullDaniel Stenberg
2017-03-22make: introduce 'test-nonflaky' targetDaniel Stenberg
Running this in the root build dir will invoke the test suite to only run tests not marked as 'flaky'.
2017-03-22test2033: flakyDaniel Stenberg
2017-03-21mbedtls: add support for CURLOPT_SSL_CTX_FUNCTIONAles Mlakar
Ref: https://curl.haxx.se/mail/lib-2017-02/0097.html Closes https://github.com/curl/curl/pull/1272
2017-03-21cmake: add support for building HTML and PDF docsPeter Wu
Note that for some reason there is this warning (that also exists with autotools, added since curl-7_15_1-94-ga718cb05f): docs/libcurl/curl_multi_socket_all.3:1: can't open `man3/curl_multi_socket.3': No such file or directory Additionally, adjust the roffit --mandir option to support creating links when doing out-of-tree builds. Ref: https://github.com/curl/curl/pull/1288
2017-03-21cmake: build manual pages (including curl.1)Peter Wu
Also make Perl mandatory to allow building the docs. While CMakeLists.txt could probably read the list of manual pages from Makefile.am, actually putting those in CMakeLists.txt is cleaner so that is what is done here. Fixes #1230 Ref: https://github.com/curl/curl/pull/1288
2017-03-21docs: split file lists into Makefile.incPeter Wu
For easier sharing with CMake. The contents were reformatted to use two-space indent and expanded tabs (matching lib/Makefile.common). Ref: https://github.com/curl/curl/pull/1288
2017-03-21examples: comment typos in http2 examplesDaniel Stenberg
2017-03-21RELEASE-NOTES: typoDaniel Stenberg
2017-03-21RELEASE-NOTES: synced with 6e0f26c8a8c28dfDaniel Stenberg
2017-03-21multi: fix streamclose() crash in debug modeDaniel Stenberg
The code would refer to the wrong data pointer. Only debug builds do this - for verbosity. Reported-by: zelinchen@users.noreply.github.com Fixes #1329
2017-03-21CONTRIBUTE: mention referring to github issues in commit msgsDaniel Stenberg
2017-03-20runtests.pl: fixed display of the Gopher IPv6 port numberDan Fandrich
2017-03-20tests: fixed the documented test server port numbersDan Fandrich
2017-03-20test714/5: added HTTP as a required featureDan Fandrich
These tests use an HTTP proxy so require that curl be built with HTTP support.
2017-03-20tests: strip more options from non-HTTP --libcurl testsDan Fandrich
The CURLOPT_USERAGENT and CURLOPT_MAXREDIRS options are only set if HTTP support is available, so ignore them in tests where HTTP is not guaranteed.
2017-03-18darwinssl: fix typo in variable namePalo Markovic
Broken a week ago in 6448f98. Closes https://github.com/curl/curl/pull/1337
2017-03-16tool_operate: Fix showing HTTPS-Proxy options on CURLE_SSL_CACERTJay Satiro
- Show the HTTPS-proxy options on CURLE_SSL_CACERT if libcurl was built with HTTPS-proxy support. Prior to this change those options were shown only if an HTTPS-proxy was specified by --proxy, but that did not take into account environment variables such as http_proxy, https_proxy, etc. Follow-up to e1187c4. Bug: https://github.com/curl/curl/issues/1331 Reported-by: Nehal J Wani
2017-03-16CURLINFO_LOCAL_PORT.3: fix typoJay Satiro
2017-03-16CURLINFO_LOCAL_PORT.3: added exampleDaniel Stenberg
2017-03-16SSLCERTS.md: mention HTTPS proxies and their separate optionsDaniel Stenberg
2017-03-15BINDINGS: a Delphi bindingDaniel Stenberg
2017-03-14KNOWN_BUGS: remove libidn related issueDaniel Stenberg
... as we no longer use libidn
2017-03-14build: removed redundant DEPENDENCIES from makefilesDan Fandrich
2017-03-13Improve code readbilitySylvestre Ledru
... by removing the else branch after a return, break or continue. Closes #1310
2017-03-13winbuild: add basic support for OpenSSL 1.1.xAnatol Belski
- Auto-detect OpenSSL 1.1 libs Closes https://github.com/curl/curl/pull/1322
2017-03-13RELEASE-NOTES: synced with c25e0761d0fc49c4Daniel Stenberg
2017-03-13make: regenerate docs/curl.1 by runinng make in docsDaniel Stenberg
... previously, docs/ was only a dist subdir, now also a build subdir. Reported-by: Dan Fandrich Bug: https://curl.haxx.se/mail/lib-2017-03/0017.html
2017-03-12test1440/1: depend on well-defined file: behaviourDan Fandrich
Depend on the known behaviour of URLs for nonexistent files rather than the undefined behaviour of URLs for directories (which fails on Windows). The test isn't about file: URLs at all, so the URL used doesn't really matter.
2017-03-12tests: clear the SSL_CERT_FILE variable on --libcurl testsDan Fandrich
Otherwise, the contents will end up in the output and fail the verification.
2017-03-12test1287: added verbose logs keywordDan Fandrich
2017-03-12tool_writeout: fixed a buffer read overrun on --write-outDan Fandrich
If a % ended the statement, the string's trailing NUL would be skipped and memory past the end of the buffer would be accessed and potentially displayed as part of the --write-out output. Added tests 1440 and 1441 to check for this kind of condition. Reported-by: Brian Carpenter