aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-07-16Don't abort Negotiate auth when the server has a response for usDavid Woodhouse
It's wrong to assume that we can send a single SPNEGO packet which will complete the authentication. It's a *negotiation* — the clue is in the name. So make sure we handle responses from the server. Curl_input_negotiate() will already handle bailing out if it thinks the state is GSS_S_COMPLETE (or SEC_E_OK on Windows) and the server keeps talking to us, so we should avoid endless loops that way.
2014-07-16Don't clear GSSAPI state between each exchange in the negotiationDavid Woodhouse
GSSAPI doesn't work very well if we forget everything ever time. XX: Is Curl_http_done() the right place to do the final cleanup?
2014-07-16Use SPNEGO for HTTP NegotiateDavid Woodhouse
This is the correct way to do SPNEGO. Just ask for it Now I correctly see it trying NTLMSSP authentication when a Kerberos ticket isn't available. Of course, we bail out when the server responds with the challenge packet, since we don't expect that. But I'll fix that bug next...
2014-07-16Remove all traces of FBOpenSSL SPNEGO supportDavid Woodhouse
This is just fundamentally broken. SPNEGO (RFC4178) is a protocol which allows client and server to negotiate the underlying mechanism which will actually be used to authenticate. This is *often* Kerberos, and can also be NTLM and other things. And to complicate matters, there are various different OIDs which can be used to specify the Kerberos mechanism too. A SPNEGO exchange will identify *which* GSSAPI mechanism is being used, and will exchange GSSAPI tokens which are appropriate for that mechanism. But this SPNEGO implementation just strips the incoming SPNEGO packet and extracts the token, if any. And completely discards the information about *which* mechanism is being used. Then we *assume* it was Kerberos, and feed the token into gss_init_sec_context() with the default mechanism (GSS_S_NO_OID for the mech_type argument). Furthermore... broken as this code is, it was never even *used* for input tokens anyway, because higher layers of curl would just bail out if the server actually said anything *back* to us in the negotiation. We assume that we send a single token to the server, and it accepts it. If the server wants to continue the exchange (as is required for NTLM and for SPNEGO to do anything useful), then curl was broken anyway. So the only bit which actually did anything was the bit in Curl_output_negotiate(), which always generates an *initial* SPNEGO token saying "Hey, I support only the Kerberos mechanism and this is its token". You could have done that by manually just prefixing the Kerberos token with the appropriate bytes, if you weren't going to do any proper SPNEGO handling. There's no need for the FBOpenSSL library at all. The sane way to do SPNEGO is just to *ask* the GSSAPI library to do SPNEGO. That's what the 'mech_type' argument to gss_init_sec_context() is for. And then it should all Just Work™. That 'sane way' will be added in a subsequent patch, as will bug fixes for our failure to handle any exchange other than a single outbound token to the server which results in immediate success.
2014-07-16ntlm_wb: Avoid invoking ntlm_auth helper with empty usernameDavid Woodhouse
2014-07-16ntlm_wb: Fix hard-coded limit on NTLM auth packet sizeDavid Woodhouse
Bumping it to 1KiB in commit aaaf9e50ec is all very well, but having hit a hard limit once let's just make it cope by reallocating as necessary.
2014-07-16RELEASE-NOTES: synced with 4cb2521595Daniel Stenberg
2014-07-16test506: verify aa6884845168Daniel Stenberg
After the fixed cookie lock deadlock, this test now passes and it detects double-locking and double-unlocking of mutexes.
2014-07-15cookie: avoid mutex deadlockYousuke Kimoto
... by removing the extra mutex locks around th call to Curl_flush_cookies() which takes care of the locking itself already. Bug: http://curl.haxx.se/mail/lib-2014-02/0184.html
2014-07-15gnutls: fix compiler warningDaniel Stenberg
conversion to 'int' from 'long int' may alter its value
2014-07-15test320: strip off the actual negotiated cipher widthDan Fandrich
It's irrelevant to the test, and will change depending on which SSL library is being used by libcurl.
2014-07-14gnutls: detect lack of SRP support in GnuTLS at run-time and try withoutDan Fandrich
Reported-by: David Woodhouse
2014-07-14configure: respect host tool prefix for krb5-configMichał Górny
Use ${host_alias}-krb5-config if available. This improves cross- compilation support and fixes multilib on Gentoo (at least).
2014-07-14gnutls: handle IP address in cert name checkDavid Woodhouse
Before GnuTLS 3.3.6, the gnutls_x509_crt_check_hostname() function didn't actually check IP addresses in SubjectAltName, even though it was explicitly documented as doing so. So do it ourselves...
2014-07-14build: set _POSIX_PTHREAD_SEMANTICS on Solaris to get proper getpwuid_rDan Fandrich
2014-07-14RELEASE-NOTES: next one is called 7.37.1Daniel Stenberg
2014-07-13gnutls: improved error message if setting cipher list failsDan Fandrich
Reported-by: David Woodhouse
2014-07-13netrc: fixed thread safety problem by using getpwuid_r if availableDan Fandrich
The old way using getpwuid could cause problems in programs that enable reading from netrc files simultaneously in multiple threads. Reported-by: David Woodhouse
2014-07-12RELEASE-NOTES: add the reporter of the previous bug fixDan Fandrich
2014-07-12netrc: treat failure to find home dir same as missing netrc fileDan Fandrich
This previously caused a fatal error (with a confusing error code, at that). Reported by: Glen A Johnson Jr.
2014-07-12RELEASE-NOTES: Synced with aaaf9e50ecSteve Holme
2014-07-12ntlm_wb: Fixed buffer size not being large enough for NTLMv2 sessionsSteve Holme
Bug: http://curl.haxx.se/mail/lib-2014-07/0103.html Reported-by: David Woodhouse
2014-07-12build: Fixed overridden compiler PDB settings in VC7 to VC12Steve Holme
The curl tool project files for VC7 to VC12 would override the default setting with the output filename being the same as the linker PDB file. As such the compiler file would be overwritten with the linker file for all debug builds. To avoid this overwrite and for consistency with the libcurl project files, removed the setting to force the default filename to be used.
2014-07-12tests: added globbing keyword to URL globbing testsDan Fandrich
2014-07-12Fixed some "statement not reached" warningsDan Fandrich
2014-07-12gnutls: fixed a couple of uninitialized variable referencesDan Fandrich
2014-07-12gnutls: fixed compilation against versions < 2.12.0Dan Fandrich
The AES-GCM ciphers were added to GnuTLS as late as ver. 3.0.1 but the code path in which they're referenced here is only ever used for somewhat older GnuTLS versions. This caused undeclared identifier errors when compiling against those.
2014-07-12gnutls: explicitly added SRP to the priority stringDan Fandrich
This seems to have become necessary for SRP support to work starting with GnuTLS ver. 2.99.0. Since support for SRP was added to GnuTLS before the function that takes this priority string, there should be no issue with backward compatibility.
2014-07-11tests: adjust for capitalization differences in newer gnutls-servDan Fandrich
2014-07-11test320/1/2/4: fix the port number substitution variablesDan Fandrich
These tests have been broken since commit 1958fe57 in Oct. 2011
2014-07-11tests: document more test identifiers and variablesDan Fandrich
2014-07-11gnutls: ignore invalid certificate dates with VERIFYPEER disabledDan Fandrich
This makes the behaviour consistent with what happens if a date can be extracted from the certificate but is expired.
2014-07-10CURLOPT_UPLOAD: Corrected argument typeSteve Holme
2014-07-09FAQ: expand the thread-safe sectionDaniel Stenberg
... with a mention of *NOSIGNAL, based on talk in bug #1386
2014-07-09url.c: Fixed memory leak on OOMDan Fandrich
This showed itself on some systems with torture failures in tests 1060 and 1061
2014-07-05Update instances of some obsolete CURLOPTs to their new namesDan Fandrich
2014-07-05compiler warnings: potentially uninitialized variablesMarcel Raad
... pointed out by MSVC2013 Bug: http://curl.haxx.se/bug/view.cgi?id=1391
2014-07-04nss: make the list of CRL items globalKamil Dudka
Otherwise NSS could use an already freed item for another connection.
2014-07-04nss: fix a memory leak when CURLOPT_CRLFILE is usedKamil Dudka
2014-07-04nss: make crl_der allocated on heapKamil Dudka
... and spell it as crl_der instead of crlDER
2014-07-04nss: let nss_{cache,load}_crl return CURLcodeKamil Dudka
2014-07-03tool: oops, forgot to include <plarenas.h>Kamil Dudka
... that contains the declaration of PL_ArenaFinish()
2014-07-03tool: call PL_ArenaFinish() on exit if NSPR is usedKamil Dudka
This prevents valgrind from reporting still reachable memory allocated by NSPR arenas (mainly the freelist). Reported-by: Hubert Kario
2014-07-03example: use correct type (long) for CURLOPT_FOLLOWLOCATIONDimitrios Siganos
2014-07-03Document type of argument for CURLOPT_FOLLOWLOCATION.Dimitrios Siganos
2014-07-03Document type of argument for CURLOPT_ERRORBUFFER.Dimitrios Siganos
2014-07-03Document type of argument for CURLOPT_COPYPOSTFIELDS.Dimitrios Siganos
2014-07-03Document type of argument for CURLOPT_ADDRESS_SCOPE.Dimitrios Siganos
2014-07-03curl.1: minor language fixDaniel Stenberg
Bug: http://curl.haxx.se/mail/archive-2014-07/0006.html
2014-07-02progress callback: skip last callback update on errorsRay Satiro
When an error has been detected, skip the final forced call to the progress callback by making sure to pass the current return code variable in the Curl_done() call in the CURLM_STATE_DONE state. This avoids the "extra" callback that could occur even if you returned error from the progress callback. Bug: http://curl.haxx.se/mail/lib-2014-06/0062.html Reported by: Jonathan Cardoso Machado
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 04:42:07 +0000