aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-02-26imap: Added a helper function for upcoming untagged response filteringJiri Hruska
RFC 3501 states that "the client MUST be prepared to accept any response at all times" yet we assume anything received with "* " at the beginning is the untagged response we want. Introduced a helper function that checks whether the input looks like a response to specified command, so that we may filter the ones we are interested in according to the current state.
2013-02-26imap: Moved CAPABILITY response handling to imap_state_capability_resp()Jiri Hruska
Introduced similar handling to the FETCH responses, where even the untagged data responses are handled by the response handler of the individual state.
2013-02-26Remove unused variable in smtp_state_data_resp()Linus Nielsen Feltzing
2013-02-25email: Small tidy up following recent changesSteve Holme
2013-02-25smtp: Removed bytecountp from the per-request structureSteve Holme
Removed this pointer to a downloaded bytes counter because it was set in smtp_init() to point to the same variable the transfer functions keep the count in (k->bytecount), effectively making the code in transfer.c "*k->bytecountp = k->bytecount" a no-op.
2013-02-25pop3: Removed bytecountp from the per-request structureSteve Holme
Removed this pointer to a downloaded bytes counter because it was set in pop3_init() to point to the same variable the transfer functions keep the count in (k->bytecount), effectively making the code in transfer.c "*k->bytecountp = k->bytecount" a no-op.
2013-02-25imap: Removed bytecountp from the per-request structureJiri Hruska
Removed this pointer to a downloaded bytes counter because it was set in imap_init() to point to the same variable the transfer functions keep the count in (k->bytecount), effectively making the code in transfer.c "*k->bytecountp = k->bytecount" a no-op.
2013-02-25imap: Adjusted SELECT and FETCH function orderJiri Hruska
Moved imap_select() and imap_fetch() to be grouped with the other perform functions.
2013-02-25imap: Adjusted SELECT and FETCH state order in imap_statemach_act()Jiri Hruska
Exchanged the position of these states in the switch statements to match the state enum, execution and function order.
2013-02-25imap: Minor tidy up of comments in imap_parse_url_path()Steve Holme
Tidy up of comments before next round of imap changes.
2013-02-25imap: Fixed incorrect comparison for STARTTLS in imap_endofresp()Steve Holme
Corrected the comparison type in addition to commit 1dac29fa83a9.
2013-02-25DOCS: Corrected IMAP URL examples according to RFC5092Steve Holme
URL examples that included the UID weren't technically correct although would pass the curl parser.
2013-02-24darwinssl: fix undefined $ssllib warning in runtests.plNick Zitzmann
I also added --with-darwinssl to the list of SSL options in configure.
2013-02-24imap: Added check for new internal imap response codeSteve Holme
2013-02-24imap: Changed the order of the response types in imap_endofresp()Steve Holme
From a maintenance point of view the code reads better to view tagged responses, then untagged followed by continuation responses. Additionally, this matches the order of responses in POP3.
2013-02-24imap: Added stricter parsing of continuation responsesJiri Hruska
Enhanced the parsing to only allow continuation responses in some states.
2013-02-24imap: Simplified memcmp() in tagged response parsingSteve Holme
2013-02-24imap: Reworked the logic of untagged command responsesJiri Hruska
2013-02-24imap: Corrected spacing of trailing braceSteve Holme
2013-02-24imap: Added stricter parsing of tagged command responsesJiri Hruska
Enhanced the parsing of tagged responses which must start with "OK", "NO" or "BAD"
2013-02-24imap: Simplified command response test in imap_endofresp()Jiri Hruska
2013-02-24imap: Corrected comment in imap_endofresp()Jiri Hruska
2013-02-24DOCS: Corrected layout of POP3 and IMAP URL examplesSteve Holme
Corrected layout issues with the POP3 and IMAP URL examples introduced in commit cb3ae6894fb2.
2013-02-23DOCS: Updated CURLOPT_URL section following recent POP3 and IMAP changesSteve Holme
Updated the POP3 sub-section to refer to message ID rather than mailbox. Added an IMAP sub-section with example URLs depicting the specification of mailbox, uid and section.
2013-02-23pop3: Refactored the mailbox variable as it didn't reflect it's purposeSteve Holme
Updated the mailbox variable to correctly reflect it's purpose. The name mailbox was a leftover from when IMAP and POP3 support was initially added to curl.
2013-02-23FEATURES: Updated following recent IMAP changesSteve Holme
2013-02-23imap: Added the ability to FETCH a specific UID and SECTIONJiri Hruska
Updated the FETCH command to send the UID and SECTION parsed from the URL. By default the BODY specifier doesn't include a section, BODY[] is now sent whereas BODY[TEXT] was previously sent. In my opinion retrieving just the message text is rarely useful when dealing with emails, as the headers are required for example, so that functionality is not retained. In can however be simulated by adding SECTION=TEXT to the URL. Also updated test801 and test1321 due to the BODY change.
2013-02-23email: Additional tidy up of comments following recent changesSteve Holme
2013-02-23smtp: Removed some FTP heritage leftoversSteve Holme
Removed user and passwd from the SMTP struct as these cannot be set on a per-request basis and are leftover from legacy FTP code. Changed some comments still using FTP terminology.
2013-02-23smtp: Moved the per-request variables to the per-request data structureSteve Holme
Moved the rcpt variable from the per-connection struct smtp_conn to the new per-request struct and fixed references accordingly.
2013-02-23pop3: Introduced a custom SMTP structure for per-request dataSteve Holme
Created a new SMTP structure and changed the type of the smtp proto variable in connectdata from FTP* to SMTP*.
2013-02-23imap: Minor correction of comments for max line lengthSteve Holme
2013-02-23strcasestr: remove check for this unused functionDaniel Stenberg
2013-02-23pop3: fix compiler warningDaniel Stenberg
error: declaration of 'pop3' shadows a previous local
2013-02-23imap: Added URL parsing of new variablesJiri Hruska
Updated the imap_parse_url_path() function to parse uidvalidity, uid and section parameters based on RFC-5092.
2013-02-23imap: Introduced imap_is_bchar() functionJiri Hruska
Added imap_is_bchar() for testing if a given character is a valid bchar or not.
2013-02-23imap: Introduced new per-request veriablesJiri Hruska
Added uidvalidity, uid and section variables to the per-request IMAP structure in preparation for upcoming URL parsing.
2013-02-23pingpong: Renamed curl_ftptransfer to curl_pp_transferSteve Holme
2013-02-23pop3: Removed some FTP heritage leftoversSteve Holme
Removed user and passwd from the POP3 struct as these cannot be set on a per-request basis and are leftover from legacy FTP code. Changed some comments still using FTP terminology.
2013-02-23pop3: Moved the per-request variables to the per-request data structureSteve Holme
Moved the mailbox and custom request variables from the per-connection struct pop3_conn to the new per-request struct and fixed references accordingly.
2013-02-23pop3: Introduced a custom POP3 structure for per-request dataSteve Holme
Created a new POP3 structure and changed the type of the pop3 proto variable in connectdata from FTP* to POP*.
2013-02-23imap: Fixed escaping of mailbox namesJiri Hruska
Used imap_atom() to escape mailbox names in imap_select().
2013-02-23pingpong: Moved curl_ftptransfer definition to pingpong.hSteve Holme
Moved the ftp transfer structure into pingpong.h so other protocols that require it don't have to include ftp.h.
2013-02-23urldata.h: Fixed comment for opt_no_body variableSteve Holme
Corrected comment for opt_no_body variable to CURLOPT_NOBODY.
2013-02-23email: Minor tidy up following IMAP changesSteve Holme
2013-02-23imap: Removed more FTP leftoversJiri Hruska
Changed some variables and comments still using FTP terminology.
2013-02-23imap: Removed some FTP heritage leftoversJiri Hruska
Removed user and passwd from the IMAP struct as these cannot be set on a per-request basis and are leftover from legacy FTP code.
2013-02-23imap: Introduced a custom IMAP structure for per-request dataJiri Hruska
Created a new IMAP structure and changed the type of the imap proto variable in connectdata from FTP* to the new IMAP*. Moved the mailbox variable from the per-connection struct imap_conn to the new per-request struct and fixed references accordingly.
2013-02-22pop3: Updated do phrase clean-up commentSteve Holme
Following commit 65644b833532 for the IMAP module updated the clean-up comment in POP3.
2013-02-22imap: Fixed memory leak when performing multiple selectsSteve Holme
Moved the clean-up of the mailbox variable from imap_disconnect() to imap_done() as this variable is allocated in the do phase, yet would have only been freed only once if multiple selects where preformed on a single connection.