aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-16ntlm: enable NTLM support with wolfSSLRuurd Beerstra
When wolfSSL is built with its OpenSSL API layer, it fetures the same DES* functions that OpenSSL has. This change take advantage of that. Co-authored-by: Daniel Stenberg Closes #5556 Fixes #5548
2020-06-15http: move header storage to Curl_easy from connectdataDaniel Stenberg
Since the connection can be used by many independent requests (using HTTP/2 or HTTP/3), things like user-agent and other transfer-specific data MUST NOT be kept connection oriented as it could lead to requests getting the wrong string for their requests. This struct data was lingering like this due to old HTTP1 legacy thinking where it didn't mattered.. Fixes #5566 Closes #5567
2020-06-13CODE_REVIEW.md: how to do code reviews in curlDaniel Stenberg
Assisted-by: Daniel Gustafsson Assisted-by: Rich Salz Assisted-by: Hugo van Kemenade Assisted-by: James Fuller Assisted-by: Marc Hörsken Assisted-by: Jay Satiro Closes #5555
2020-06-12altsvc: remove the num field from the altsvc structDaniel Stenberg
It was superfluous since we have the list.size alredy Reported-by: Jay Satiro Fixes #5553 Closes #5563
2020-06-12version.d: expanded and alpha-sortedDaniel Stenberg
Added a few missing features not previously mentioned. Ordered them alphabetically. Closes #5558
2020-06-12ABI.md: rename to .md and polish the markdownDaniel Stenberg
Closes #5562
2020-06-12HELP-US: add a section for "smaller tasks"Daniel Stenberg
The point of this section is to meet the CII Best Practices gold level critera: "The project MUST clearly identify small tasks that can be performed by new or casual contributors" Closes #5560
2020-06-12TODO: retry on the redirected-to URLDaniel Stenberg
Closes #5462
2020-06-12mailmap: Nicolas StercheleDaniel Stenberg
2020-06-12TODO: remove 19.3 section titleSterchele Nicolas
Follow-up to ad6416986755e417c66e2c6, which caused wrong formatting on curl documentation website Closes #5561
2020-06-12test1560: avoid possibly negative association in wordingMartin V
Closes #5549
2020-06-12share: don't set the share flag it something failsDaniel Stenberg
When asking for a specific feature to be shared in the share object, that bit was previously set unconditionally even if the shared feature failed or otherwise wouldn't work. Closes #5554
2020-06-10buildconf: remove -print from the find command that removes filesDaniel Stenberg
It's just too annoying and unnecessary to get a long list of files shown
2020-06-10RELEASE-NOTES: syncedDaniel Stenberg
2020-06-10wording: avoid blacklist/whitelist stereotypesDaniel Stenberg
Instead of discussing if there's value or meaning (implied or not) in the colors, let's use words without the same possibly negative associations. Closes #5546
2020-06-09tool_getparam: fix memory leak in parse_argsJay Satiro
Prior to this change in Windows Unicode builds most parsed options would not be freed. Found using _CrtDumpMemoryLeaks(). Ref: https://github.com/curl/curl/issues/5545
2020-06-08socks: detect connection close during handshakeDaniel Stenberg
The SOCKS4/5 state machines weren't properly terminated when the proxy connection got closed, leading to a busy-loop. Reported-By: zloi-user on github Fixes #5532 Closes #5542
2020-06-08multi: add defensive check on data->multi->num_alivexquery
Closes #5540
2020-06-08Curl_addrinfo: use one malloc instead of threeDaniel Stenberg
To reduce the amount of allocations needed for creating a Curl_addrinfo struct, make a single larger malloc instead of three separate smaller ones. Closes #5533
2020-06-08quiche: update SSLKEYLOGFILE supportAlessandro Ghedini
quiche now requires the application to explicitly set the keylog path for each connection, rather than reading the environment variable itself. Closes #5541
2020-06-08tests: add two simple tests for --login-optionsDaniel Stenberg
Test 895 and 896 - as a follow-up to a3e972313b Closes #5539
2020-06-08ngtcp2: update with recent API changesDaniel Stenberg
Syncs with ngtcp2 commit 7e9a917d386d98 merged June 7 2020. Assisted-by: Tatsuhiro Tsujikawa Closes #5538
2020-06-08socks: remove unreachable breaks in socks.c and mime.cxquery
Closes #5537
2020-06-08tool_cfgable: free login_options at exitDaniel Stenberg
Memory leak Reported-by: Geeknik Labs Fixes #5535 Closes #5536
2020-06-08libssh2: keep sftp errors as 'unsigned long'Daniel Stenberg
Remove weird work-around for storing the SFTP errors as int instead of the "unsigned long" that libssh2 actually returns for SFTP errors. Closes #5534
2020-06-06timeouts: move ms timeouts to timediff_t from int and longMarc Hoersken
Now that all functions in select.[ch] take timediff_t instead of the limited int or long, we can remove type conversions and related preprocessor checks to silence compiler warnings. Avoiding conversions from time_t was already done in 842f73de. Based upon #5262 Supersedes #5214, #5220 and #5221 Follow up to #5343 and #5479 Closes #5490
2020-06-06openssl: set FLAG_TRUSTED_FIRST unconditionallyFrançois Rigault
On some systems, openssl 1.0.x is still the default, but it has been patched to contain all the recent security fixes. As a result of this patching, it is possible for macro X509_V_FLAG_NO_ALT_CHAINS to be defined, while the previous behavior of openssl to not look at trusted chains first, remains. Fix it: ensure X509_V_FLAG_TRUSTED_FIRST is always set, do not try to probe for the behavior of openssl based on the existence ofmacros. Closes #5530
2020-06-06server/util: fix logmsg format using curl_off_t argumentDaniel Stenberg
... this caused segfaults on armv7. Regression added in dd0365d560aea5a (7.70.0) Reviewed-by: Jay Satiro Closes #5529
2020-06-05RELEASE-NOTES: syncedDaniel Stenberg
2020-06-05socks: fix expected length of SOCKS5 replyCherish98
Commit 4a4b63d forgot to set the expected SOCKS5 reply length when the reply ATYP is X'01'. This resulted in erroneously expecting more bytes when the request length is greater than the reply length (e.g., when remotely resolving the hostname). Closes #5527
2020-06-05.gitignore: add directory containing the stats repoMarc Hoersken
Since the new curl/stats repository is designed to be checked out into the curl repository working tree as stats/ it should be on the ignore list to aid in commit staging.
2020-06-05HTTP3.md: clarify cargo build directoryAdnan Khan
Cargo needs to be called from within the 'quiche' directory. Closes #5522
2020-06-05user-agent.d: spell out what happens given a blank argumentDaniel Stenberg
Closes #5525
2020-06-05trailers: switch h1-trailer logic to use dynbufDaniel Stenberg
In the continued effort to remove "manual" realloc schemes. Closes #5524
2020-06-05CURLINFO_ACTIVESOCKET.3: clarify the descriptionDaniel Stenberg
Reported-by: Jay Satiro Fixes #5299 Closes #5520
2020-06-04mailmap: Don J OlmsteadDaniel Stenberg
2020-06-04configure: only strip first -L from LDFLAGSDaniel Stenberg
In the logic that works out if a given OpenSSL path works, it stripped off a possibly leading -L flag using an incorrect sed pattern which would remove all instances of -L in the string, including if the path itself contained that two-letter sequence! The same pattern was used and is now updated in multiple places. Now it only removes -L if it starts the strings. Reported-by: Mohamed Osama Fixes #5519 Closes #5521
2020-06-04quiche: advertise draft 28 supportPeter Wu
Fix the verbose message while at it, quiche currently supports draft 27 and draft 28 simultaneously. Closes #5518
2020-06-04KNOWN_BUGS: RTSP authentication breaks without redirect supportDaniel Stenberg
Closes #4750
2020-06-04projects: Add crypt32.lib to dependencies for all OpenSSL configsJay Satiro
Windows project configurations that use OpenSSL with USE_WIN32_CRYPTO need crypt32. Follow-up to 148534d which added CURLSSLOPT_NATIVE_CA for 7.71.0. The changes that are in this commit were made by script. Ref: https://gist.github.com/jay/a1861b50ecce2b32931237180f856e28 Closes https://github.com/curl/curl/pull/5516
2020-06-03CI/macos: fix 'is already installed' errors by using bundleMarc Hoersken
Avoid failing CI builds due to nghttp2 being already installed. Closes #5513
2020-06-03altsvc: fix 'dsthost' may be used uninitialized in this functionDaniel Stenberg
2020-06-02RELEASE-NOTES: syncedDaniel Stenberg
2020-06-02urldata: let the HTTP method be in the set.* structDaniel Stenberg
When the method is updated inside libcurl we must still not change the method as set by the user as then repeated transfers with that same handle might not execute the same operation anymore! This fixes the libcurl part of #5462 Test 1633 added to verify. Closes #5499
2020-06-02hostip: fix the memory-leak introduced in 67d2802Daniel Stenberg
Fixes #5503 Closes #5504
2020-06-02test970: make it require proxy supportDaniel Stenberg
This test verifies the -w %json output and the test case includes a full generated "blob". If there's no proxy support built into libcurl, it will return an error for proxy related info variables and they will not be included in the json, thus causing a mismatch and this test fails. Reported-by: Marc Hörsken Fixes #5501 Closes #5502
2020-06-02examples/http2-down/upload: add error checksRadoslav Georgiev
If `index.html` does not exist in the directory from which the example is invoked, the fopen(upload, "rb") invocation in `setup` would fail, returning NULL. This value is subsequently passed as the FILE* argument of the `fread` invocation in the `read_callback` function, which is the actual cause of the crash (apparently `fread` assumes that argument to be non-null). In addition, mitigate some possible crashes of similar origin. Closes #5463
2020-06-02examples/ephiperfifo: turn off interval when setting timerfdkotoriのねこ
Reported-by: therealhirudo on github Fixes #5485 Closes #5497
2020-06-01vtls: repair the build with `CURL_DISABLE_PROXY`Saleem Abdulrasool
`http_proxy` will not be available in `conndata` if `CURL_DISABLE_PROXY` is enabled. Repair the build with that configuration. Follow-up to f3d501dc67 Closes #5498
2020-06-01transfer: remove k->str NULL checkDaniel Stenberg
"Null-checking k->str suggests that it may be null, but it has already been dereferenced on all paths leading to the check" - and it can't legally be NULL at this point. Remove check. Detected by Coverity CID 1463884 Closes #5495