aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-14multi: fix the transfer hash functionDaniel Stenberg
Follow-up from 8b987cc7eb Reported-by: Tom van der Woerdt Fixes #4018 Closes #4024
2019-06-13unit1654: cleanup on memory failureDaniel Stenberg
... to make it handle torture tests properly. Reported-by: Marcel Raad Fixes #4021 Closes #4022
2019-06-13krb5: fix compiler warningMarcel Raad
Even though the variable was used in a DEBUGASSERT, GCC 8 warned in debug mode: krb5.c:324:17: error: unused variable 'maj' [-Werror=unused-variable] Just suppress the warning and declare the variable unconditionally instead of only for DEBUGBUILD (which also missed the check for HAVE_ASSERT_H). Closes https://github.com/curl/curl/pull/4020
2019-06-13quote.d: asterisk prefix works for SFTP as wellDaniel Stenberg
Reported-by: Ben Voris Fixes #4017 Closes #4019
2019-06-12multi: fix the transfer hashes in the socket hash entriesDaniel Stenberg
- The transfer hashes weren't using the correct keys so removing entries failed. - Simplified the iteration logic over transfers sharing the same socket and they now simply are set to expire and thus get handled in the "regular" timer loop instead. Reported-by: Tom van der Woerdt Fixes #4012 Closes #4014
2019-06-12url: Fix CURLOPT_MAXAGE_CONN time comparisonCliff Crosland
Old connections are meant to expire from the connection cache after CURLOPT_MAXAGE_CONN seconds. However, they actually expire after 1000x that value. This occurs because a time value measured in milliseconds is accidentally divided by 1M instead of by 1,000. Closes https://github.com/curl/curl/pull/4013
2019-06-11test1165: verify that CURL_DISABLE_ symbols are in syncDaniel Stenberg
between configure.ac and source code. They should be possible to switch on/off in configure AND be used in source code.
2019-06-11configure: remove CURL_DISABLE_TLS_SRPDaniel Stenberg
It isn't used by code so stop providing the define. Closes #4010
2019-06-11Revert "cmake: add SMB to list of disabled protocols if HTTP_ONLY is specified"Daniel Stenberg
This reverts commit 36738caeb78603ce24e3ea089a167b8c216fb938. Apparently several of the appveyor windows builds broke.
2019-06-11cmake: add SMB to list of disabled protocols if HTTP_ONLY is specifiedsergey-raevskiy
Reviewed-by: Jakub Zakrzewski Closes #3770
2019-06-11RELEASE-NOTES: syncedDaniel Stenberg
2019-06-11http2: remove CURL_DISABLE_TYPECHECK defineDaniel Stenberg
... in http2-less builds as it served no use.
2019-06-11configure: more --disable switches to toggle off individual featuresDaniel Stenberg
... actual support in the code for disabling these has already landed. Closes #4009
2019-06-11wolfssl: fix key pinning build errorDaniel Stenberg
follow-up from deb9462ff2de8
2019-06-10CURLMOPT_SOCKETFUNCTION.3: clarifiedDaniel Stenberg
Moved away the callback explanation from curl_multi_socket_action.3 and expanded it somewhat. Closes #4006
2019-06-10wolfssl: fixup for SNI useDaniel Stenberg
follow-up from deb9462ff2de8 Closes #4007
2019-06-10CURLOPT_CAINFO.3: polished wordingDaniel Stenberg
Clarify the functionality when built to use Schannel and Secure Transport and stop calling it the "recommended" or "preferred" way and instead rather call it the default. Removed the reference to the ssl comparison table as it isn't necessary. Reported-by: Richard Alcock Bug: https://curl.haxx.se/mail/lib-2019-06/0019.html Closes #4005
2019-06-10SECURITY.md: createdDaniel Stenberg
Brief security policy description for use/display on github.
2019-06-10tool_cb_prg: Fix integer overflow in progress barDaniel Gustafsson
Commit 61faa0b420c236480bc9ef6fd52b4ecc1e0f8d17 fixed the progress bar width calculation to avoid integer overflow, but failed to account for the fact that initial_size is initialized to -1 when the file size is retrieved from the remote on an upload, causing another signed integer overflow. Fix by separately checking for this case before the width calculation. Closes #3984 Reported-by: Brian Carpenter (Geeknik Labs) Reviewed-by: Daniel Stenberg <daniel@haxx.se>
2019-06-10wolfssl: refer to it as wolfSSL onlyDaniel Stenberg
Remove support for, references to and use of "cyaSSL" from the source and docs. wolfSSL is the current name and there's no point in keeping references to ancient history. Assisted-by: Daniel Gustafsson Closes #3903
2019-06-10RELEASE-NOTES: syncedDaniel Stenberg
2019-06-10bindlocal: detect and avoid IP version mismatches in bind()Daniel Stenberg
Reported-by: Alex Grebenschikov Fixes #3993 Closes #4002
2019-06-10multi: make sure 'data' can present in several sockhash entriesDaniel Stenberg
Since more than one socket can be used by each transfer at a given time, each sockhash entry how has its own hash table with transfers using that socket. In addition, the sockhash entry can now be marked 'blocked = TRUE'" which then makes the delete function just set 'removed = TRUE' instead of removing it "for real", as a way to not rip out the carpet under the feet of a parent function that iterates over the transfers of that same sockhash entry. Reported-by: Tom van der Woerdt Fixes #3961 Fixes #3986 Fixes #3995 Fixes #4004 Closes #3997
2019-06-09libcurl-tutorial.3: Fix small typo (mutipart -> multipart)Sorcus
Fixed-by: MrSorcus on github Closes #4000
2019-06-09unpause: trigger a timeout for event-based transfersDaniel Stenberg
... so that timeouts or other state machine actions get going again after a changing pause state. For example, if the last delivery was paused there's no pending socket activity. Reported-by: sstruchtrup on github Fixes #3994 Closes #4001
2019-06-09travis: use xenial LLVM package for scan-buildMarcel Raad
I missed that in commit 99a49d6.
2019-06-09travis: update scan-build job to xenialMarcel Raad
Closes https://github.com/curl/curl/pull/3999
2019-06-08bump: start working on 7.65.2Daniel Stenberg
2019-06-05examples/htmltitle: use C++ casts between pointer typesMarcel Raad
Compilers and static analyzers warn about using C-style casts here. Closes https://github.com/curl/curl/pull/3975
2019-06-05examples/fopen: fix comparisonMarcel Raad
As want is size_t, (file->buffer_pos - want) is unsigned, so checking if it's less than zero makes no sense. Check if file->buffer_pos is less than want instead to avoid the unsigned integer wraparound. Closes https://github.com/curl/curl/pull/3975
2019-06-05build: fix Codacy warningsMarcel Raad
Reduce variable scopes and remove redundant variable stores. Closes https://github.com/curl/curl/pull/3975
2019-06-05sws: remove unused variablesMarcel Raad
Unused since commit 2f44e94. Closes https://github.com/curl/curl/pull/3975
2019-06-04RELEASE-NOTES: 7.65.1Daniel Stenberg
2019-06-04THANKS: new contributors from 7.65.1Daniel Stenberg
2019-06-04ssl: Update outdated "openssl-only" comments for supported backendsFrank Gevaerts
These are for features that used to be openssl-only but were expanded over time to support other SSL backends. Closes #3985
2019-06-04curl_share_setopt.3: improve wording [ci ship]Daniel Stenberg
Reported-by: Carlos ORyan
2019-06-04tool_parsecfg: Use correct return type for GetModuleFileName()Steve Holme
GetModuleFileName() returns a DWORD which is a typedef of an unsigned long and not an int. Closes #3980
2019-06-03TODO: "at least N milliseconds between requests" [ci skip]Daniel Stenberg
Suggested-by: dkwolfe4 on github Closes #3920
2019-06-02tests/server/.gitignore: Add socksd to the ignore listSteve Holme
Missed in 04fd6755. Closes #3978
2019-06-02tool_parsecfg: Fix control flow issue (DEADCODE)Steve Holme
Follow-up to 8144ba38. Detected by Coverity CID 1445663 Closes #3976
2019-06-02NTLM: reset proxy "multipass" state when CONNECT request is doneSergey Ogryzkov
Closes #3972
2019-06-02test334: verify HTTP 204 response with chunked coding headerDaniel Stenberg
Verifies that a bodyless response don't parse this content-related header.
2019-06-02http: don't parse body-related headers bodyless responsesMichael Kaufmann
Responses with status codes 1xx, 204 or 304 don't have a response body. For these, don't parse these headers: - Content-Encoding - Content-Length - Content-Range - Last-Modified - Transfer-Encoding This change ensures that HTTP/2 upgrades work even if a "Content-Length: 0" or a "Transfer-Encoding: chunked" header is present. Co-authored-by: Daniel Stenberg Closes #3702 Fixes #3968 Closes #3977
2019-06-02tls13-docs: mention it is only for OpenSSL >= 1.1.1Daniel Stenberg
Reported-by: Jay Satiro Co-authored-by: Jay Satiro Fixes #3938 Closes #3946
2019-06-01dump-header.d: spell out that no headers == empty file [ci skip]Daniel Stenberg
Reported-by: wesinator at github Fixes #3964 Closes #3974
2019-06-01singlesocket: use separate variable for inner loopDaniel Stenberg
An inner loop within the singlesocket() function wrongly re-used the variable for the outer loop which then could cause an infinite loop. Change to using a separate variable! Reported-by: Eric Wu Fixes #3970 Closes #3973
2019-05-31RELEASE-NOTES: syncedDaniel Stenberg
2019-05-30http2: Stop drain from being permanently set onJosie Huddleston
Various functions called within Curl_http2_done() can have the side-effect of setting the Easy connection into drain mode (by calling drain_this()). However, the last time we unset this for a transfer (by calling drained_transfer()) is at the beginning of Curl_http2_done(). If the Curl_easy is reused for another transfer, it is then stuck in drain mode permanently, which in practice makes it unable to write any data in the new transfer. This fix moves the last call to drained_transfer() to later in Curl_http2_done(), after the functions that could potentially call for a drain. Fixes #3966 Closes #3967 Reported-by: Josie-H
2019-05-29conncache: Remove the DEBUGASSERT on length checkSteve Holme
We trust the calling code as this is an internal function. Closes #3962
2019-05-29system_win32: fix function prototypeGisle Vanem
- Change if_nametoindex parameter type from char * to const char *. Follow-up to 09eef8af from this morning. Bug: https://github.com/curl/curl/commit/09eef8af#r33716067