aboutsummaryrefslogtreecommitdiff
path: root/lib/pop3.c
AgeCommit message (Collapse)Author
2013-04-28pop3: Added 255 octet limit check when sending initial responseSteve Holme
Added 255 octet limit check as per Section 4. Paragraph 8 of RFC-5034.
2013-04-27pop3: Added support for enabling the SASL initial responseSteve Holme
Allowed the user to specify whether to send the client's intial response in the AUTH command via CURLOPT_SASL_IR.
2013-04-15pop3: Added missing comment for pop3_state_apop_resp()Steve Holme
2013-04-15pop3: Updated the coding style of pop3_state_servergreet_resp()Steve Holme
Updated the coding style, in this function, to be consistent with other response functions rather then performing a hard return on failure.
2013-04-14pop3: Re-factored all perform based functionsSteve Holme
Standardised the naming of all perform based functions to be in the form pop3_perform_something() following the changes made to IMAP.
2013-04-14pop3: Added description comments to all perform based functionsSteve Holme
2013-04-14pop3: Moved pop3_quit() to be with the other perform functionsSteve Holme
2013-04-14pop3: Moved pop3_command() to be with the other perform functionsSteve Holme
Started to apply the same tidy up to the POP3 code as applied to the IMAP code in the 7.30.0 release.
2013-04-13pop3: Added support for ;auth=<mech> in the URLSteve Holme
Added support for specifying the preferred authentication type and SASL mechanism in the URL as per RFC-2384.
2013-04-12pop3: Reworked the function description for Curl_pop3_write()Steve Holme
2013-04-12pop3: Added function description to pop3_parse_custom_request()Steve Holme
2013-04-12pop3: Moved utility functions to end of pop3.cSteve Holme
2013-03-13pop3: Removed unnecessary transfer cancellationSteve Holme
Following commit e450f66a02d8 and the changes in the multi interface being used internally, from 7.29.0, the transfer cancellation in pop3_dophase_done() is no longer required.
2013-03-12pop3: Fixed continuous wait when using --ftp-listSteve Holme
Don't initiate a transfer when using --ftp-list.
2013-03-09email: Removed hard returns from init functionsSteve Holme
2013-03-09email: Updated the function descriptions for the logout / quit functionsSteve Holme
Updated the function description comments following commit 4838d196fdbf.
2013-03-09email: Simplified the logout / quit functionsSteve Holme
Moved the blocking state machine to the disconnect functions so that the logout / quit functions are only responsible for sending the actual command needed to logout or quit. Additionally removed the hard return on failure.
2013-03-08email: Tidied up the *_regular_transfer() functionsSteve Holme
Added comments and simplified convoluted dophase_done comparison.
2013-03-08email: Simplified nesting of if statements in *_doing() functionsSteve Holme
2013-03-07email: Minor code tidy up following recent changesSteve Holme
Removed unwanted braces and added variable initialisation.
2013-03-07email: Optimised block_statemach() functionsSteve Holme
Optimised the result test in each of the block_statemach() functions.
2013-03-03pop3: Updated the coding style for state changes after a send operationSteve Holme
Some state changes would be performed after a failure test that performed a hard return, whilst others would be performed within a test for success. Updated the code, for consistency, so all instances are performed within a success test.
2013-03-03pop3: Fixed unnecessary parent structure referenceSteve Holme
Updated pop3 code following recent imap changes.
2013-02-28pop3 / smtp: Small comment tidy upSteve Holme
Small tidy up to keep some comments consistant across each of the email protocols.
2013-02-28pop3: Small tidy up of function argumentsSteve Holme
2013-02-28pop3: Corrected debug message for POP3_AUTH_FINAL constantSteve Holme
Following commit afad1ce753a1 corrected the debug message in state() from AUTH to AUTH_FINAL.
2013-02-27pop3: Re-factored the final POP3_AUTH constantSteve Holme
Changed the final POP3_AUTH constant to POP3_AUTH_FINAL for consistency with the response function.
2013-02-25email: Small tidy up following recent changesSteve Holme
2013-02-25pop3: Removed bytecountp from the per-request structureSteve Holme
Removed this pointer to a downloaded bytes counter because it was set in pop3_init() to point to the same variable the transfer functions keep the count in (k->bytecount), effectively making the code in transfer.c "*k->bytecountp = k->bytecount" a no-op.
2013-02-23pop3: Refactored the mailbox variable as it didn't reflect it's purposeSteve Holme
Updated the mailbox variable to correctly reflect it's purpose. The name mailbox was a leftover from when IMAP and POP3 support was initially added to curl.
2013-02-23email: Additional tidy up of comments following recent changesSteve Holme
2013-02-23pop3: fix compiler warningDaniel Stenberg
error: declaration of 'pop3' shadows a previous local
2013-02-23pop3: Removed some FTP heritage leftoversSteve Holme
Removed user and passwd from the POP3 struct as these cannot be set on a per-request basis and are leftover from legacy FTP code. Changed some comments still using FTP terminology.
2013-02-23pop3: Moved the per-request variables to the per-request data structureSteve Holme
Moved the mailbox and custom request variables from the per-connection struct pop3_conn to the new per-request struct and fixed references accordingly.
2013-02-23pop3: Introduced a custom POP3 structure for per-request dataSteve Holme
Created a new POP3 structure and changed the type of the pop3 proto variable in connectdata from FTP* to POP*.
2013-02-23email: Minor tidy up following IMAP changesSteve Holme
2013-02-22pop3: Updated do phrase clean-up commentSteve Holme
Following commit 65644b833532 for the IMAP module updated the clean-up comment in POP3.
2013-02-16email: Tidied up result code variablesSteve Holme
Tidied up result variables to be consistent in name, declaration order and default values.
2013-02-16email: Removed unnecessary forward declarationSteve Holme
Due to the reordering of functions in commit 586f5d361474 the forward declaration to state_upgrade_tls() are no longer required.
2013-02-16pop3.c: Added reference to RFC-5034Steve Holme
2013-02-15pop3: Removed unnecessary state changes on failureSteve Holme
2013-02-15rename "easy" statemachines: call them block insteadDaniel Stenberg
... since they're not used by the easy interface really, I wanted to remove the association. Also, I unified the pingpong statemachine driver into a single function with a 'wait' argument: Curl_pp_statemach.
2013-02-14pop3: Fixed blocking SSL connect when connecting via POP3SSteve Holme
A call to Curl_ssl_connect() was accidentally left in when the SSL/TLS connection layer was reworked in 7.29. Not only would this cause the connection to block but had the additional overhead of calling the non-blocking connect a little bit later.
2013-02-13email: Tidy up before additional IMAP workSteve Holme
Replaced two explicit comparisons of CURLE_OK with boolean alternatives. General tidy up of comments.
2013-02-12email: Another post optimisation of endofresp() tidy upSteve Holme
2013-02-12email: Post optimisation of endofresp() tidy upSteve Holme
Removed unnecessary end of line check and return.
2013-02-12pingpong: Optimised the endofresp() functionSteve Holme
Reworked the pp->endofresp() function so that the conndata, line and line length are passed down to it just as with Curl_client_write() rather than each implementation of the function having to query these values. Additionally changed the int return type to bool as this is more representative of the function's usage.
2013-02-11email: Post STARTLS capability code tidy up (Part Three)Steve Holme
Corrected the order of the upgrade_tls() functions and moved the handler upgrade and getsock() functions out from the middle of the state related functions.
2013-02-11email: Post STARTLS capability code tidy up (Part Two)Steve Holme
Corrected the order of the pop3_state_capa() / imap_state_capability() and the pop3_state_capa_resp() / imap_state_capability_resp() functions to match the execution order.
2013-02-10email: Post STARTLS capability code tidy up (Part One)Steve Holme
Corrected the order of the CAPA / CAPABILITY state machine constants to match the execution order.