aboutsummaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2014-12-20non-ascii: Reduce variable scopeSteve Holme
As 'result' isn't used out side the conversion callback code and previously caused variable shadowing in the libiconv based code.
2014-12-19non-ascii: We prefer 'CURLcode result'Steve Holme
This also fixes a variable shadowing issue when HAVE_ICONV is defined as rc was declared for the result code of libiconv based functions.
2014-12-18if2ip: dummy scope parameter for Curl_if2ip() call in SIOCGIFADDR-enabled code.Patrick Monnerat
2014-12-17parseurlandfillconn(): fix improper non-numeric scope_id stripping.Kyle J. McKay
Fixes SF bug 1149: http://sourceforge.net/p/curl/bugs/1449/
2014-12-16IPV6: address scope != scope idPatrick Monnerat
There was a confusion between these: this commit tries to disambiguate them. - Scope can be computed from the address itself. - Scope id is scope dependent: it is currently defined as 1-based local interface index for link-local scoped addresses, and as a site index(?) for (obsolete) site-local addresses. Linux only supports it for link-local addresses. The URL parser properly parses a scope id as an interface index, but stores it in a field named "scope": confusion. The field has been renamed into "scope_id". Curl_if2ip() used the scope id as it was a scope. This caused failures to bind to an interface. Scope is now computed from the addresses and Curl_if2ip() matches them. If redundantly specified in the URL, scope id is check for mismatch with the interface index. This commit should fix SF bug #1451.
2014-12-16connect: singleipconnect(): properly try other address families after failurePatrick Monnerat
2014-12-16SFTP: work-around servers that return zero size on STATDaniel Stenberg
Bug: http://curl.haxx.se/mail/lib-2014-12/0103.html Pathed-by: Marc Renault
2014-12-15darwinssl: fix incorrect usage of aprintf()Nick Zitzmann
Commit b13923f changed an snprintf() to use aprintf(), but the API usage wasn't correct, and was causing a crash to occur. This fixes it.
2014-12-14copyright: Updated the copyright year following recent updatesSteve Holme
2014-12-14lib: Fixed multiple code analysis warnings if SAL are availableMarc Hoersken
warning C28252: Inconsistent annotation for function: parameter has another annotation on this instance
2014-12-14smb.c: Fixed code analysis warningSteve Holme
smb.c:320: warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Result may not be an expected value
2014-12-14smb: Use HAVE_PROCESS_H for process.h inclusionSteve Holme
Rather than testing against _WIN32 use the preferred HAVE_PROCESS_H pre-processor define when including process.h.
2014-12-14darwinssl: aprintf() to allocate the session keyDaniel Stenberg
... to avoid using a fixed memory size that risks being too large or too small.
2014-12-14curl_schannel: Improvements to memory re-allocation strategyMarc Hoersken
- do not grow memory by doubling its size - do not leak previously allocated memory if reallocation fails - replace while-loop with a single check to make sure that the requested amount of data fits into the buffer Bug: http://curl.haxx.se/bug/view.cgi?id=1450 Reported-by: Warren Menzer
2014-12-14asyn-ares: We prefer use of 'CURLcode result'Steve Holme
2014-12-14curl_schannel.c: Data may be available before connection shutdownMarc Hoersken
2014-12-14http2: Use 'CURLcode result' for curl result codesSteve Holme
2014-12-14asyn-thread: We prefer 'CURLcode result'Steve Holme
2014-12-14smb: Fixed unnecessary initialisation of struct member variablesSteve Holme
There is no need to set the 'state' and 'result' member variables to SMB_REQUESTING (0) and CURLE_OK (0) after the allocation via calloc() as calloc() initialises the contents to zero.
2014-12-14ntlm: Fixed return code for bad type-2 Target InfoSteve Holme
Use CURLE_BAD_CONTENT_ENCODING for bad type-2 Target Info security buffers just like we do for bad decodes.
2014-12-14ntlm: Remove unnecessary casts in readshort_le()Steve Holme
I don't think both of my fix ups from yesterday were needed to fix the compilation warning, so remove the one that I think is unnecessary and let the next Android autobuild prove/disprove it.
2014-12-13curl_ntlm_msgs.c: Another attempt to fix compilation warningSteve Holme
curl_ntlm_msgs.c:170: warning: conversion to 'short unsigned int' from 'int' may alter its value
2014-12-13smb.c: Fixed line longer than 79 columnsSteve Holme
2014-12-13curl_ntlm_msgs.c: Fixed compilation warning from commit 783b5c3b11Steve Holme
curl_ntlm_msgs.c:169: warning: conversion to 'short unsigned int' from 'int' may alter its value
2014-12-13mk-ca-bundle.pl: restored forced run again.Guenter Knauf
2014-12-13ftp.c: Fixed compilation warning when no verbose string supportSteve Holme
ftp.c:819: warning: unused parameter 'lineno'
2014-12-13smb: Added state change functions to assist with debuggingSteve Holme
For debugging purposes, and as per other protocols within curl, added state change functions rather than changing the states directly.
2014-12-13ntlm: Use short integer when decoding 16-bit valuesSteve Holme
2014-12-12smtp.c: Fixed compilation warningsSteve Holme
smtp.c:2357 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string smtp.c:2375 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string smtp.c:2386 warning: adding 'size_t' (aka 'unsigned long') to a string does not append to the string Used array index notation instead.
2014-12-12smb: Disable SMB when 64-bit integers are not supportedSteve Holme
This fixes compilation issues with compilers that don't support 64-bit integers through long long or __int64.
2014-12-12ntlm: Disable NTLM v2 when 64-bit integers are not supportedSteve Holme
This fixes compilation issues with compilers that don't support 64-bit integers through long long or __int64 which was introduced in commit 07b66cbfa4.
2014-12-12ntlm: Allow NTLM2Session messages when USE_NTRESPONSES manually definedSteve Holme
Previously USE_NTLM2SESSION would only be defined automatically when USE_NTRESPONSES wasn't already defined. Separated the two definitions so that the user can manually set USE_NTRESPONSES themselves but USE_NTLM2SESSION is defined automatically if they don't define it.
2014-12-12smtp.c: Fixed line longer than 79 columnsSteve Holme
2014-12-12config-win32.h: Don't enable Windows Crypt API if using OpenSSLSteve Holme
As the OpenSSL and NSS Crypto engines are prefered by the core NTLM routines, to the Windows Crypt API, don't define USE_WIN32_CRYPT automatically when either OpenSSL or NSS are in use - doing so would disable NTLM2Session responses in NTLM type-3 messages.
2014-12-12smtp: Fixed inappropriate free of the scratch bufferSteve Holme
If the scratch buffer was allocated in a previous call to Curl_smtp_escape_eob(), a new buffer not allocated in the subsequent call and no action taken by that call, then an attempt would be made to try and free the buffer which, by now, would be part of the data->state structure. This bug was introduced in commit 4bd860a001.
2014-12-12smtp: Fixed dot stuffing when EOL characters were at end of input buffersSteve Holme
Fixed a problem with the CRLF. detection when multiple buffers were used to upload an email to libcurl and the line ending character(s) appeared at the end of each buffer. This meant any lines which started with . would not be escaped into .. and could be interpreted as the end of transmission string instead. This only affected libcurl based applications that used a read function and wasn't reproducible with the curl command-line tool. Bug: http://curl.haxx.se/bug/view.cgi?id=1456 Assisted-by: Patrick Monnerat
2014-12-11telnet: fix "cast increases required alignment of target type"Daniel Stenberg
2014-12-10ntlm_wb_response: fix "statement not reached"Daniel Stenberg
... and I could use a break instead of a goto to end the loop. Bug: http://curl.haxx.se/mail/lib-2014-12/0089.html Reported-by: Tor Arntsen
2014-12-10Curl_unix2addr: avoid using the variable name 'sun'Daniel Stenberg
I suspect this causes compile failures on Solaris: Bug: http://curl.haxx.se/mail/lib-2014-12/0081.html
2014-12-10url.c: Fixed compilation warning when USE_NTLM is not definedSteve Holme
url.c:3078: warning: variable 'credentialsMatch' set but not used
2014-12-10parsedate.c: Fixed compilation warningSteve Holme
parsedate.c:548: warning: 'parsed' may be used uninitialized in this function As curl_getdate() returns -1 when parsedate() fails we can initialise parsed to -1.
2014-12-10ldap: check Curl_client_write() return codesDaniel Stenberg
There might be one or two memory leaks left in the error paths.
2014-12-10ldap: rename variables to comply to curl standardsDaniel Stenberg
2014-12-09cookies: Improved OOM handling in cookiesDan Fandrich
This fixes the test 506 torture test. The internal cookie API really ought to be improved to separate cookie parsing errors (which may be ignored) with OOM errors (which should be fatal).
2014-12-09smb: fix unused return code warningDaniel Stenberg
2014-12-09Curl_client_write() & al.: chop long data, convert data only once.Patrick Monnerat
2014-12-09schannel_recv: return the correct codeDaniel Stenberg
Bug: http://curl.haxx.se/bug/view.cgi?id=1462 Reported-by: Tae Hyoung Ahn
2014-12-09http2: avoid logging neg "failure" if h2 was not requestedDaniel Stenberg
2014-12-08openldap: do not ignore Curl_client_write() return codesDaniel Stenberg
2014-12-08compile: warn on unused return code from Curl_client_write()Daniel Stenberg