| Age | Commit message (Collapse) | Author | 
|---|
|  | vtls.c:683:43: warning: unused parameter 'data' | 
|  |  | 
|  | curl_schannel.h:123: warning: right-hand operand of comma expression
                     has no effect
Some instances of the curlssl_close_all() function were declared with a
void return type whilst others as int. The schannel version returned
CURLE_NOT_BUILT_IN and others simply returned zero, but in all cases the
return code was ignored by the calling function Curl_ssl_close_all().
For the time being and to keep the internal API consistent, changed all
declarations to use a void return type.
To reduce code we might want to consider removing the unimplemented
versions and use a void #define like schannel does. | 
|  |  | 
|  | This frees up the 'result' variable for CURLcode based result codes. | 
|  |  | 
|  |  | 
|  | ...and don't use CURLE_OK in failure/success comparisons. | 
|  |  | 
|  |  | 
|  |  | 
|  |  | 
|  | For consistency, as we seem to have a bit of a mixed bag, changed all
instances of ipv4 and ipv6 in comments and documentations to use the
correct case. | 
|  | Use Unix when generically writing about Unix based systems as UNIX is
the trademark and should only be used in a particular product's name. | 
|  | if2ip.c:119: warning: unused parameter 'remote_scope_id'
...and some minor code style policing in the same function. | 
|  | Otherwise Curl_ssl_init_certinfo() can fail and set the num_of_certs
member variable to the requested count, which could then be used
incorrectly as libcurl closes down. | 
|  | The return type for this function was 0 on success and 1 on error. This
was then examined by the calling functions and, in most cases, used to
return CURLE_OUT_OF_MEMORY.
Instead use CURLcode for the return type and return the out of memory
error directly, propagating it up the call stack. | 
|  | The return type of this function is a boolean value, and even uses a
bool internally, so use bool in the function declaration as well as
the variables that store the return value, to avoid any confusion. | 
|  |  | 
|  |  | 
|  |  | 
|  | curl_ntlm_core.c:301: warning: pointer targets in passing argument 2 of
                      'CryptImportKey' differ in signedness
curl_ntlm_core.c:310: warning: passing argument 6 of 'CryptEncrypt' from
                      incompatible pointer type
curl_ntlm_core.c:540: warning: passing argument 4 of 'CryptGetHashParam'
                      from incompatible pointer type | 
|  |  | 
|  | Renamed ldap_setup() to ldap_setup_connection() to follow more widely
used function naming. | 
|  | Renamed rtmp_setup() to rtmp_setup_connection() to follow more widely
used function naming. | 
|  | Renamed smb_setup() to smb_setup_connection() to follow more widely
used function naming. | 
|  |  | 
|  |  | 
|  | openssl.c:1408: error: 'TLS1_1_VERSION' undeclared
openssl.c:1411: error: 'TLS1_2_VERSION' undeclared | 
|  |  | 
|  |  | 
|  | ... as it requires TLS and it was was left to warn on the default from
when default was SSL... | 
|  | ... as it never copies the trailing zero anyway and always just the four
bytes so let's not mislead anyone into thinking it is actually treated
as a string.
Coverity CID: 1260214 | 
|  | lib/setup-vms.h : VAX HP OpenSSL port is ancient, needs help.
                  More defines to set symbols to uppercase.
src/tool_main.c : Fix parameter to vms_special_exit() call.
packages/vms/ :
  backup_gnv_curl_src.com : Fix the error message to have the correct package.
  build_curl-config_script.com : Rewrite to be more accurate.
  build_libcurl_pc.com : Use tool_version.h now.
  build_vms.com : Fix to handle lib/vtls directory.
  curl_gnv_build_steps.txt : Updated build procedure documentation.
  generate_config_vms_h_curl.com :
       * VAX does not support 64 bit ints, so no NTLM support for now.
       * VAX HP SSL port is ancient, needs some help.
       * Disable NGHTTP2 for now, not ported to VMS.
       * Disable UNIX_SOCKETS, not available on VMS yet.
       * HP GSSAPI port does not have gss_nt_service_name.
  gnv_link_curl.com : Update for new curl structure.
  pcsi_product_gnv_curl.com : Set up to optionally do a complete build. | 
|  | Removed 'next' variable in Curl_convert_form(). Rather than setting it
from 'form->next' and using that to set 'form' after the conversion
just use 'form = form->next' instead. | 
|  | This also removes the need to check that the 'form' argument is valid. | 
|  | As 'result' isn't used out side the conversion callback code and
previously caused variable shadowing in the libiconv based code. | 
|  | This also fixes a variable shadowing issue when HAVE_ICONV is defined
as rc was declared for the result code of libiconv based functions. | 
|  |  | 
|  | Fixes SF bug 1149: http://sourceforge.net/p/curl/bugs/1449/ | 
|  | There was a confusion between these: this commit tries to disambiguate them.
- Scope can be computed from the address itself.
- Scope id is scope dependent: it is currently defined as 1-based local
  interface index for link-local scoped addresses, and as a site index(?) for
  (obsolete) site-local addresses. Linux only supports it for link-local
  addresses.
The URL parser properly parses a scope id as an interface index, but stores it
in a field named "scope": confusion. The field has been renamed into "scope_id".
Curl_if2ip() used the scope id as it was a scope. This caused failures
to bind to an interface.
Scope is now computed from the addresses and Curl_if2ip() matches them.
If redundantly specified in the URL, scope id is check for mismatch with
the interface index.
This commit should fix SF bug #1451. | 
|  |  | 
|  | Bug: http://curl.haxx.se/mail/lib-2014-12/0103.html
Pathed-by: Marc Renault | 
|  | Commit b13923f changed an snprintf() to use aprintf(), but the API usage
wasn't correct, and was causing a crash to occur. This fixes it. | 
|  |  | 
|  | warning C28252: Inconsistent annotation for function:
parameter has another annotation on this instance | 
|  | smb.c:320: warning C6297: Arithmetic overflow: 32-bit value is shifted,
           then cast to 64-bit value. Result may not be an expected
           value | 
|  | Rather than testing against _WIN32 use the preferred HAVE_PROCESS_H
pre-processor define when including process.h. | 
|  | ... to avoid using a fixed memory size that risks being too large or too
small. | 
|  | - do not grow memory by doubling its size
- do not leak previously allocated memory if reallocation fails
- replace while-loop with a single check to make sure
  that the requested amount of data fits into the buffer
Bug: http://curl.haxx.se/bug/view.cgi?id=1450
Reported-by: Warren Menzer |