aboutsummaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2010-06-05OpenSSL: fix spurious SSL connection abortsConstantine Sapuntzakis
Was seeing spurious SSL connection aborts using libcurl and OpenSSL. I tracked it down to uncleared error state on the OpenSSL error stack - patch attached deals with that. Rough idea of problem: Code that uses libcurl calls some library that uses OpenSSL but don't clear the OpenSSL error stack after an error. ssluse.c calls SSL_read which eventually gets an EWOULDBLOCK from the OS. Returns -1 to indicate an error ssluse.c calls SSL_get_error. First thing, SSL_get_error calls ERR_get_error to check the OpenSSL error stack, finds an old error and returns SSL_ERROR_SSL instead of SSL_ERROR_WANT_READ or SSL_ERROR_WANT_WRITE. ssluse.c returns an error and aborts the connection Solution: Clear the openssl error stack before calling SSL_* operation if we're going to call SSL_get_error afterwards. Notes: This is much more likely to happen with multi because it's easier to intersperse other calls to the OpenSSL library in the same thread.
2010-06-05replace socklen_t with curl_socklen_tYang Tse
2010-06-05getinfo: added *_PRIMARY_PORT, *_LOCAL_IP and *_LOCAL_PORTFrank Meier
2010-06-04Enable OpenLDAP support for cygwin builds.Yang Tse
Enable OpenLDAP support for cygwin builds. This support was disabled back in 2008 due to incompatibilities between OpenSSL and OpenLDAP headers. cygwin's OpenSSL 0.9.8l and OpenLDAP 2.3.43 versions on cygwin 1.5.25 allow building an OpenLDAP enabled libcurl supporting back to Windows 95. Remove non-functional CURL_LDAP_HYBRID code and references.
2010-06-02ftplistparser.c: oops, fix typo in the last commitKamil Dudka
2010-06-02ftplistparser.c: avoid some invalid dereferencesKamil Dudka
2010-06-02lib: eliminate some dead codeKamil Dudka
2010-06-02SSH: corrected the inability to respect the timeoutDaniel Stenberg
Jason McDonald posted bug report #3006786 when he found that the SFTP code didn't timeout properly in several places in the code even if a timeout was set properly. Based on his suggested patch, I wrote a different implementation that I think addressed the issue better and also uses the connect timeout for the initial part of the SSH/SFTP done during the "protocol connect" phase. (http://curl.haxx.se/bug/view.cgi?id=3006786)
2010-06-02add missing new files to non-configure target build filesYang Tse
2010-06-02include libcurl standard internal headersYang Tse
2010-06-02make setup.h first included fileYang Tse
2010-06-02fix spnego memory leakYang Tse
2010-06-02openldap header inclusions fixYang Tse
2010-06-01multi_socket: handles timer inaccuracy better for timeoutsDaniel Stenberg
Igor Novoseltsev reported a problem with the multi socket API and using timeouts and timers. It boiled down to a problem with libcurl's use of GetTickCount() interally to figure out the current time, while Igor's own application code used another function call. It made his app call the socket API timeout function a bit _before_ libcurl would consider the timeout to trigger, and that could easily lead to timeouts or stalls in the app. It seems GetTickCount() in general often has no better resolution than 16ms and switching to the alternative function QueryPerformanceCounter has its share of problems: http://www.virtualdub.org/blog/pivot/entry.php?id=106 We address this problem by simply having libcurl treat timers that already has occured or will occur within 40ms subject for treatment. I'm confident that there are other implementations and operating systems with similarly in accurate timer functions so it makes sense to have applied generically and I don't believe we sacrifice much by adding a 40ms inaccuracy on these timeouts.
2010-06-01fix ldap related compilation issuesYang Tse
2010-06-01fix compiler warning: enumerated type mixed with another typeYang Tse
2010-05-31fix compiler warning: enumerated type mixed with another typeYang Tse
2010-05-31smtp_authenticate: avoid compiler warningsPatrick Monnerat
2010-05-31fix compiler warning: enumerated type mixed with another typeYang Tse
2010-05-31fix compiler warning: enumerated type mixed with another typeYang Tse
2010-05-31fix compiler warning: enumerated type mixed with another typeYang Tse
2010-05-31fix compiler warning: external declaration in primary source fileYang Tse
2010-05-31update year in copyright noticeYang Tse
2010-05-29strtoofft: rename CURL_LLONG_MIN -> CURL_OFF_T_MINKamil Dudka
... and CURL_LLONG_MAX -> CURL_OFF_T_MAX
2010-05-29CURL_LLONG_MAX: avoid constant overflowKamil Dudka
... when (CURL_SIZEOF_CURL_OFF_T == 4)
2010-05-28LDAPS: list availability depending on SSL's presenceHoward Chu
2010-05-28LDAP: make it build without SSL if no such support is availableHoward Chu
of course it also goes for the case where SSL is explicitly disabled
2010-05-28lib: eliminate 'statement not reached' warningsKamil Dudka
2010-05-27openldap: fix compiler warningsHoward Chu
2010-05-27indent: some whitespace editsDaniel Stenberg
2010-05-27wildcard.c: add missing include of "setup.h"Kamil Dudka
2010-05-27wildcard.c: add missing include of "curl_memory.h"Pavel Raiskup
2010-05-27setup_once: use enum type for 'bool' on non-C99 platformsTor Arntsen
An enum will catch non-bool assignments to bool on platforms with a strict compiler, e.g MIPSPro. Signed-off-by: Kamil Dudka <kdudka@redhat.com>
2010-05-27url.c: avoid implied cast to boolKamil Dudka
2010-05-27curl_fnmatch: remove use of register keywordTor Arntsen
Using the 'register' keyword rarely improves anything with modern compilers and architectures.
2010-05-26RTMP: Fix compiler warningsJulien Chaffraix
2010-05-26OOM fixes in http_negociate.c and lib/splay.cJulien Chaffraix
Fix 2 OOM errors: a missing NULL-check in lib/http_negociate.c and a potential NULL dereferencing in lib/splay.c
2010-05-25LDAP: properly implemented as a curl_handlerHoward Chu
makes the LDAP code much cleaner, nicer and in general being a better libcurl citizen. If a new enough OpenLDAP version is detect, the new and shiny lib/openldap.c code is then used instead of the old cruft Code by Howard, minor cleanups by Daniel.
2010-05-21curl_fnmatch: Use int not bool when function returns intTor Arntsen
bool in curl internals is unsigned char and should not be used to receive return value from functions returning int - this fails when using IBM VisualAge and Tru64 compilers.
2010-05-21TFTP: send legal timeout valueDaniel Stenberg
Eric Mertens posted bug #3003705: when we made TFTP use the correct timeout option when sent to the server (fixed May 18th 2010) it became obvious that libcurl used invalid timeout values (300 by default while the RFC allows nothing above 255). While of course it is obvious that as TFTP has worked thus far without being able to set timeout at all, just removing the setting wouldn't make any difference in behavior. I decided to still keep it (but fix the problem) as it now actually allows for easier (future) customization of the timeout. (http://curl.haxx.se/bug/view.cgi?id=3003705)
2010-05-21TFTP: don't ack if wrong block num is receivedDaniel Stenberg
If an unexpected block number was received, break out of the switch loop.
2010-05-21TFTP: block id wrap bug fixDaniel Stenberg
In a normal expression, doing [unsigned short] + 1 will not wrap at 16 bits so the comparisons and outputs were done wrong. I added a macro do make sure it gets done right. Douglas Kilpatrick filed bug report #3004787 about it: http://curl.haxx.se/bug/view.cgi?id=3004787
2010-05-20Fix build warnings.Ben Greear
Signed-off-by: Ben Greear <greearb@candelatech.com>
2010-05-20setopt: Fix setting of set.is_fwrite_setBen Greear
Signed-off-by: Ben Greear <greearb@candelatech.com>
2010-05-20build: allow curl to build with Microsoft VC10Tanguy Fautre
By undefing a bunch of E* defines that VC10 has started to define but that we redefine internally to their WSA* alternatives when building for Windows.
2010-05-19lib: Fix AIX build failureTor Arntsen
2010-05-19Fixed some memory leaks in the POP3 torture testsDan Fandrich
2010-05-18Fixed a memory leak in the SMTP torture testsDan Fandrich
2010-05-18TFTP: send timeout option correctlyDaniel Stenberg
Eric Mertens posted bug report #3003005 pointing out that the libcurl TFTP code was not sending the timeout option properly to the server, and suggested a fix. (http://curl.haxx.se/bug/view.cgi?id=3003005)
2010-05-16lib: Change some CRLF line endings to LFTor Arntsen
An update had added a couple of lines with DOS line endings, and some compilers will choke on that (e.g. the Tru64 compiler).