From 2c5f346d3a18b829f2c9ce8dbb98470e41017ca3 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Sun, 21 Dec 2014 23:21:16 +0100 Subject: smb: use memcpy() instead of strncpy() ... as it never copies the trailing zero anyway and always just the four bytes so let's not mislead anyone into thinking it is actually treated as a string. Coverity CID: 1260214 --- lib/smb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/smb.c b/lib/smb.c index 9648f6519..a8fcf4acc 100644 --- a/lib/smb.c +++ b/lib/smb.c @@ -345,7 +345,7 @@ static void smb_format_message(struct connectdata *conn, struct smb_header *h, memset(h, 0, sizeof(*h)); h->nbt_length = htons((unsigned short) (sizeof(*h) - sizeof(unsigned int) + len)); - strncpy((char *)h->magic, "\xffSMB", 4); + memcpy((char *)h->magic, "\xffSMB", 4); h->command = cmd; h->flags = SMB_FLAGS_CANONICAL_PATHNAMES | SMB_FLAGS_CASELESS_PATHNAMES; h->flags2 = smb_swap16(SMB_FLAGS2_IS_LONG_NAME | SMB_FLAGS2_KNOWS_LONG_NAME); -- cgit v1.2.3