From 3789e2e6ce705ce4c23c672dc5f05aa254b451c0 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Fri, 9 Mar 2007 21:51:38 +0000 Subject: - Justin Fletcher fixed a file descriptor leak in the curl tool when trying to upload a file it couldn't open. Bug #1676581 (http://curl.haxx.se/bug/view.cgi?id=1676581) --- CHANGES | 5 +++++ RELEASE-NOTES | 2 +- src/main.c | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index f47d35b3b..a7466051b 100644 --- a/CHANGES +++ b/CHANGES @@ -6,6 +6,11 @@ Changelog +Daniel (9 March 2007) +- Justin Fletcher fixed a file descriptor leak in the curl tool when trying to + upload a file it couldn't open. Bug #1676581 + (http://curl.haxx.se/bug/view.cgi?id=1676581) + Dan F (9 March 2007) - Updated the test harness to check for protocol support before running each test, fixing KNOWN_BUGS #11. diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 079d7d0ce..636a0d91b 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -58,6 +58,6 @@ advice from friends like these: Yang Tse, Manfred Schwarb, Michael Wallner, Jeff Pohlmeyer, Shmulik Regev, Rob Crittenden, Robert A. Monat, Dan Fandrich, Duncan Mac-Vicar Prett, Michal Marek, Robson Braga Araujo, Ian Turner, Linus Nielsen Feltzing, - Ravi Pratap, Adam D. Moss, Jose Kahan, Hang Kin Lau + Ravi Pratap, Adam D. Moss, Jose Kahan, Hang Kin Lau, Justin Fletcher Thanks! (and sorry if I forgot to mention someone) diff --git a/src/main.c b/src/main.c index fcc519245..ae7455037 100644 --- a/src/main.c +++ b/src/main.c @@ -3931,6 +3931,8 @@ operate(struct Configurable *config, int argc, char *argv[]) infd=(FILE *) fopen(uploadfile, "rb"); if (!infd || stat(uploadfile, &fileinfo)) { helpf("Can't open '%s'!\n", uploadfile); + if(infd) + fclose(infd); return CURLE_READ_ERROR; } infdfopen=TRUE; -- cgit v1.2.3