From 49f3117a238b6eac0e22a32f50699a9eddcb66ab Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 19 Sep 2019 09:18:26 +0200 Subject: ftp: Expression 'ftpc->wait_data_conn' is always false Fixes warning detected by PVS-Studio Fixes #4374 --- lib/ftp.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/ftp.c b/lib/ftp.c index a4a37c9af..4cd9a1acf 100644 --- a/lib/ftp.c +++ b/lib/ftp.c @@ -3570,13 +3570,8 @@ static CURLcode ftp_do_more(struct connectdata *conn, int *completep) return result; result = ftp_multi_statemach(conn, &complete); - if(ftpc->wait_data_conn) - /* if we reach the end of the FTP state machine here, *complete will be - TRUE but so is ftpc->wait_data_conn, which says we need to wait for - the data connection and therefore we're not actually complete */ - *completep = 0; - else - *completep = (int)complete; + /* ftpc->wait_data_conn is always false here */ + *completep = (int)complete; } else { /* download */ -- cgit v1.2.3