From 4ef6d6b1bc8c4345f81531274492f188c8e99976 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Mon, 14 Mar 2016 10:50:53 +0100 Subject: curl: glob_range: no need to check unsigned variable for negative cppcheck warned: [src/tool_urlglob.c:283]: (style) Checking if unsigned variable 'step_n' is less than zero. --- src/tool_urlglob.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/tool_urlglob.c b/src/tool_urlglob.c index f1dd27fad..70d17fed1 100644 --- a/src/tool_urlglob.c +++ b/src/tool_urlglob.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2015, Daniel Stenberg, , et al. + * Copyright (C) 1998 - 2016, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -279,8 +279,7 @@ static CURLcode glob_range(URLGlob *glob, char **patternp, *posp += (pattern - *patternp); - if(!endp || (min_n > max_n) || (step_n > (max_n - min_n)) || - (step_n <= 0) ) + if(!endp || (min_n > max_n) || (step_n > (max_n - min_n)) || !step_n) /* the pattern is not well-formed */ return GLOBERROR("bad range", *posp, CURLE_URL_MALFORMAT); -- cgit v1.2.3