From 80d0dcc9a3124dcecc9d1f7296f2ac429bc7d704 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Sun, 19 Oct 2008 18:20:47 +0000 Subject: clarified an argument's situation due to a false positive alert pointed out by coverity.com --- lib/url.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/url.c b/lib/url.c index 45567b6a0..040a64cd1 100644 --- a/lib/url.c +++ b/lib/url.c @@ -4355,8 +4355,8 @@ static CURLcode create_conn(struct SessionHandle *data, */ static CURLcode setup_conn(struct connectdata *conn, - struct Curl_dns_entry *hostaddr, - bool *protocol_done) + struct Curl_dns_entry *hostaddr, + bool *protocol_done) { CURLcode result=CURLE_OK; struct SessionHandle *data = conn->data; @@ -4402,7 +4402,12 @@ static CURLcode setup_conn(struct connectdata *conn, if(CURL_SOCKET_BAD == conn->sock[FIRSTSOCKET]) { bool connected = FALSE; - /* Connect only if not already connected! */ + /* Connect only if not already connected! + * + * NOTE: hostaddr can be NULL when passed to this function, but that is + * only for the case where we re-use an existing connection and thus + * this code section will not be reached with hostaddr == NULL. + */ result = ConnectPlease(data, conn, hostaddr, &connected); if(connected) { -- cgit v1.2.3