From 8191800a0c8ff7b262535cbf1311d93ada2ee0c4 Mon Sep 17 00:00:00 2001 From: Steve Holme Date: Sun, 17 Nov 2013 16:39:02 +0000 Subject: smtp: Fixed space being sent in non --mail-rcpt based requests Commands such as NOOP, RSET and HELP would be sent with a space at the end of the command, for example: "NOOP ". --- lib/smtp.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/smtp.c b/lib/smtp.c index 5675ff4ee..aa3ff326a 100644 --- a/lib/smtp.c +++ b/lib/smtp.c @@ -563,16 +563,16 @@ static CURLcode smtp_perform_command(struct connectdata *conn) struct SessionHandle *data = conn->data; struct SMTP *smtp = data->req.protop; - if(smtp->custom && smtp->custom[0] != '\0') - /* Send the custom command */ - result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s %s", smtp->custom, - smtp->rcpt ? smtp->rcpt->data : ""); - else if(smtp->rcpt) - /* Send the VRFY command */ - result = Curl_pp_sendf(&conn->proto.smtpc.pp, "VRFY %s", smtp->rcpt->data); + /* Send the command */ + if(smtp->rcpt) + result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s %s", + smtp->custom && smtp->custom[0] != '\0' ? + smtp->custom : "VRFY", + smtp->rcpt->data); else - /* Send the HELP command */ - result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", "HELP"); + result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", + smtp->custom && smtp->custom[0] != '\0' ? + smtp->custom : "HELP"); if(!result) state(conn, SMTP_COMMAND); -- cgit v1.2.3