From 992083b1abe2f19947abe1d5ba01c488458f6e66 Mon Sep 17 00:00:00 2001 From: Marcel Raad Date: Sat, 25 May 2019 19:24:13 +0200 Subject: examples/fopen: fix comparison As want is size_t, (file->buffer_pos - want) is unsigned, so checking if it's less than zero makes no sense. Check if file->buffer_pos is less than want instead to avoid the unsigned integer wraparound. Closes https://github.com/curl/curl/pull/3975 --- docs/examples/fopen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/fopen.c b/docs/examples/fopen.c index f1706fbe6..7151addde 100644 --- a/docs/examples/fopen.c +++ b/docs/examples/fopen.c @@ -211,7 +211,7 @@ static int fill_buffer(URL_FILE *file, size_t want) static int use_buffer(URL_FILE *file, size_t want) { /* sort out buffer */ - if((file->buffer_pos - want) <= 0) { + if(file->buffer_pos <= want) { /* ditch buffer - write will recreate */ free(file->buffer); file->buffer = NULL; -- cgit v1.2.3