From e481d679b264fba519f1e12bc7f131057b8501e9 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Wed, 7 May 2008 21:02:21 +0000 Subject: - Liam Healy filed the debian bug report #480044 (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=480044) identifying a segfault when using krb5 ftp, but the krb4 code had the same problem. --- CHANGES | 5 +++++ RELEASE-NOTES | 3 ++- lib/ftp.c | 4 ++++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index f68c4f804..51b5bbe66 100644 --- a/CHANGES +++ b/CHANGES @@ -7,6 +7,11 @@ Changelog +Daniel Stenberg (7 May 2008) +- Liam Healy filed the debian bug report #480044 + (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=480044) identifying a + segfault when using krb5 ftp, but the krb4 code had the same problem. + Yang Tse (7 May 2008) - Christopher Palow provided the patch (edited by me) that introduces the use of microsecond resolution keys for internal splay trees. diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 4ceb3f9eb..f2565fae2 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -31,6 +31,7 @@ This release includes the following bugfixes: o libcurl sometimes sent body twice when using CURLAUTH_ANY o configure detecting debug-enabled c-ares o microsecond resolution keys for internal splay trees + o krb4 and krb5 ftp segfault This release includes the following known bugs: @@ -52,6 +53,6 @@ advice from friends like these: Michal Marek, Daniel Fandrich, Scott Barrett, Alexey Simak, Daniel Black, Rafa Muyo, Andre Guibert de Bruet, Brock Noland, Sandor Feldi, Stefan Krause, David Shaw, Norbert Frese, Bart Whiteley, Jean-Francois Bertrand, Ben Van Hof, - Yuriy Sosov, Christopher Palow, Yang Tse + Yuriy Sosov, Christopher Palow, Yang Tse, Liam Healy Thanks! (and sorry if I forgot to mention someone) diff --git a/lib/ftp.c b/lib/ftp.c index 649da81d6..ba24376fe 100644 --- a/lib/ftp.c +++ b/lib/ftp.c @@ -622,9 +622,13 @@ CURLcode Curl_GetFTPResponse(ssize_t *nreadp, /* return number of bytes read */ struct timeval now = Curl_tvnow(); size_t nread; int cache_skip=0; + int value_to_be_ignored=0; if(ftpcode) *ftpcode = 0; /* 0 for errors */ + else + /* make the pointer point to something for the rest of this function */ + ftpcode = &value_to_be_ignored; *nreadp=0; -- cgit v1.2.3