From 1c3e8bbfedcd3822aeb1bab22fb56c5ecff4295b Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Wed, 14 Dec 2016 01:29:44 +0100 Subject: checksrc: warn for assignments within if() expressions ... they're already frowned upon in our source code style guide, this now enforces the rule harder. --- docs/examples/externalsocket.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'docs/examples/externalsocket.c') diff --git a/docs/examples/externalsocket.c b/docs/examples/externalsocket.c index 9b144b42d..918f08218 100644 --- a/docs/examples/externalsocket.c +++ b/docs/examples/externalsocket.c @@ -90,9 +90,8 @@ int main(void) #ifdef WIN32 WSADATA wsaData; - int initwsa; - - if((initwsa = WSAStartup(MAKEWORD(2, 0), &wsaData)) != 0) { + int initwsa = WSAStartup(MAKEWORD(2, 0), &wsaData); + if(initwsa != 0) { printf("WSAStartup failed: %d\n", initwsa); return 1; } @@ -107,7 +106,8 @@ int main(void) curl_easy_setopt(curl, CURLOPT_URL, "http://99.99.99.99:9999"); /* Create the socket "manually" */ - if((sockfd = socket(AF_INET, SOCK_STREAM, 0)) == CURL_SOCKET_BAD) { + sockfd = socket(AF_INET, SOCK_STREAM, 0); + if(sockfd == CURL_SOCKET_BAD) { printf("Error creating listening socket.\n"); return 3; } @@ -116,7 +116,8 @@ int main(void) servaddr.sin_family = AF_INET; servaddr.sin_port = htons(PORTNUM); - if(INADDR_NONE == (servaddr.sin_addr.s_addr = inet_addr(IPADDR))) + servaddr.sin_addr.s_addr = inet_addr(IPADDR); + if(INADDR_NONE == servaddr.sin_addr.s_addr) return 2; if(connect(sockfd, (struct sockaddr *) &servaddr, sizeof(servaddr)) == -- cgit v1.2.3