From 1c3e8bbfedcd3822aeb1bab22fb56c5ecff4295b Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Wed, 14 Dec 2016 01:29:44 +0100 Subject: checksrc: warn for assignments within if() expressions ... they're already frowned upon in our source code style guide, this now enforces the rule harder. --- docs/examples/rtsp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'docs/examples/rtsp.c') diff --git a/docs/examples/rtsp.c b/docs/examples/rtsp.c index bdab39542..5c66aa6e5 100644 --- a/docs/examples/rtsp.c +++ b/docs/examples/rtsp.c @@ -61,13 +61,15 @@ static int _getch(void) #define VERSION_STR "V1.0" /* error handling macros */ -#define my_curl_easy_setopt(A, B, C) \ - if((res = curl_easy_setopt((A), (B), (C))) != CURLE_OK) \ +#define my_curl_easy_setopt(A, B, C) \ + res = curl_easy_setopt((A), (B), (C)); \ + if(!res) \ fprintf(stderr, "curl_easy_setopt(%s, %s, %s) failed: %d\n", \ #A, #B, #C, res); -#define my_curl_easy_perform(A) \ - if((res = curl_easy_perform((A))) != CURLE_OK) \ +#define my_curl_easy_perform(A) \ + res = curl_easy_perform(A); \ + if(!res) \ fprintf(stderr, "curl_easy_perform(%s) failed: %d\n", #A, res); -- cgit v1.2.3