From 9c1806ae4684ec5ef1aeb39bb9f15cece1c27256 Mon Sep 17 00:00:00 2001 From: Jay Satiro Date: Sat, 30 Nov 2019 03:29:36 -0500 Subject: build: Disable Visual Studio warning "conditional expression is constant" - Disable warning C4127 "conditional expression is constant" globally in curl_setup.h for when building with Microsoft's compiler. This mainly affects building with the Visual Studio project files found in the projects dir. Prior to this change the cmake and winbuild build systems already disabled 4127 globally for when building with Microsoft's compiler. Also, 4127 was already disabled for all build systems in the limited circumstance of the WHILE_FALSE macro which disabled the warning specifically for while(0). This commit removes the WHILE_FALSE macro and all other cruft in favor of disabling globally in curl_setup. Background: We have various macros that cause 0 or 1 to be evaluated, which would cause warning C4127 in Visual Studio. For example this causes it: #define Curl_resolver_asynch() 1 Full behavior is not clearly defined and inconsistent across versions. However it is documented that since VS 2015 Update 3 Microsoft has addressed this somewhat but not entirely, not warning on while(true) for example. Prior to this change some C4127 warnings occurred when I built with Visual Studio using the generated projects in the projects dir. Closes https://github.com/curl/curl/pull/4658 --- lib/cookie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/cookie.c') diff --git a/lib/cookie.c b/lib/cookie.c index c9e420ad4..0091132aa 100644 --- a/lib/cookie.c +++ b/lib/cookie.c @@ -1227,7 +1227,7 @@ static int cookie_sort_ct(const void *p1, const void *p2) if(!d->field) \ goto fail; \ } \ - } WHILE_FALSE + } while(0) static struct Cookie *dup_cookie(struct Cookie *src) { -- cgit v1.2.3