From d765099813f58153cb859279c743e6494d179341 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Sun, 16 Feb 2014 14:07:56 +0100 Subject: ConnectionExists: re-use connections better When allowing NTLM, the re-use connection logic was too focused on finding an existing NTLM connection to use and didn't properly allow re-use of other ones. This made the logic not re-use perfectly re-usable connections. Added test case 1418 and 1419 to verify. Regression brought in 8ae35102c (curl 7.35.0) Reported-by: Jeff King Bug: http://thread.gmane.org/gmane.comp.version-control.git/242213 --- lib/url.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'lib/url.c') diff --git a/lib/url.c b/lib/url.c index 085b3a2f9..c0aebef16 100644 --- a/lib/url.c +++ b/lib/url.c @@ -3133,8 +3133,10 @@ ConnectionExists(struct SessionHandle *data, *force_reuse = TRUE; break; } - else - continue; + else if(credentialsMatch) + /* this is a backup choice */ + chosen = check; + continue; } if(canPipeline) { -- cgit v1.2.3