From 06a1b821404c176fde883a826a0db712695dd964 Mon Sep 17 00:00:00 2001 From: Patrick Monnerat Date: Tue, 28 Jan 2020 10:23:41 +0100 Subject: cookie: get_top_domain() sets zero length for null domains This silents a compilation warning with gcc -O3. --- lib/cookie.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) (limited to 'lib') diff --git a/lib/cookie.c b/lib/cookie.c index 69bc04260..68054e1c4 100644 --- a/lib/cookie.c +++ b/lib/cookie.c @@ -245,18 +245,17 @@ pathmatched: */ static const char *get_top_domain(const char * const domain, size_t *outlen) { - size_t len; + size_t len = 0; const char *first = NULL, *last; - if(!domain) - return NULL; - - len = strlen(domain); - last = memrchr(domain, '.', len); - if(last) { - first = memrchr(domain, '.', (last - domain)); - if(first) - len -= (++first - domain); + if(domain) { + len = strlen(domain); + last = memrchr(domain, '.', len); + if(last) { + first = memrchr(domain, '.', (last - domain)); + if(first) + len -= (++first - domain); + } } if(outlen) -- cgit v1.2.3