From 2c1db913f73ff29291969ca7bf6f3bf8e1f34069 Mon Sep 17 00:00:00 2001 From: Dan Fandrich Date: Wed, 30 Jul 2014 23:18:47 +0200 Subject: smtp: fixed a segfault during test 1320 torture test Under these circumstances, the connection hasn't been fully established and smtp_connect hasn't been called, yet smtp_done still calls the state machine which dereferences the NULL conn pointer in struct pingpong. --- lib/smtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/smtp.c b/lib/smtp.c index 5938c3ff4..da7601724 100644 --- a/lib/smtp.c +++ b/lib/smtp.c @@ -1642,7 +1642,7 @@ static CURLcode smtp_done(struct connectdata *conn, CURLcode status, (void)premature; - if(!smtp) + if(!smtp || !pp->conn) /* When the easy handle is removed from the multi interface while libcurl is still trying to resolve the host name, the SMTP struct is not yet initialized. However, the removal action calls Curl_done() which in -- cgit v1.2.3