From 3c8c9b2779df175f2f740bb6fbe414e0c56f94b6 Mon Sep 17 00:00:00 2001 From: Steve Holme Date: Sun, 17 Nov 2013 09:45:08 +0000 Subject: smtp: Changed the default command to HELP when no options are specified Otherwise a NOOP operation would be performed which a) only returns a single line response and not a multiline response where -I needs to be used, and b) provides an inconsistent user experience compared to that of the POP3 and IMAP protocols. --- lib/smtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/smtp.c b/lib/smtp.c index 120afaf80..5675ff4ee 100644 --- a/lib/smtp.c +++ b/lib/smtp.c @@ -571,8 +571,8 @@ static CURLcode smtp_perform_command(struct connectdata *conn) /* Send the VRFY command */ result = Curl_pp_sendf(&conn->proto.smtpc.pp, "VRFY %s", smtp->rcpt->data); else - /* Send the NOOP command */ - result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", "NOOP"); + /* Send the HELP command */ + result = Curl_pp_sendf(&conn->proto.smtpc.pp, "%s", "HELP"); if(!result) state(conn, SMTP_COMMAND); -- cgit v1.2.3